Re: Logging in Django

2010-06-20 Thread Russell Keith-Magee
2010/6/21 Ian Lewis : > On Sun, Jun 20, 2010 at 12:19 PM, Russell Keith-Magee > wrote: >> On Sun, Jun 20, 2010 at 4:59 AM, David North >> wrote: >>> On 28/05/2010 16:48, Russell Keith-Magee wrote: >>> * They have to be sprinkled all over the place (or in a lot of places, at >>> least) rather than

Re: Logging in Django

2010-06-20 Thread Ian Lewis
On Sun, Jun 20, 2010 at 12:19 PM, Russell Keith-Magee wrote: > On Sun, Jun 20, 2010 at 4:59 AM, David North > wrote: >> On 28/05/2010 16:48, Russell Keith-Magee wrote: >> * They have to be sprinkled all over the place (or in a lot of places, at >> least) rather than the logging aspect of the appl

Re: Logging in Django

2010-06-19 Thread Russell Keith-Magee
On Sun, Jun 20, 2010 at 4:59 AM, David North wrote: > On 28/05/2010 16:48, Russell Keith-Magee wrote: >> >> The second commit will be the addition of actual logging. The >> intention here is to be initially conservative; two immediate targets >> would be to replace calls to mail_admins() with logg

Re: Logging in Django

2010-06-19 Thread David North
On 28/05/2010 16:48, Russell Keith-Magee wrote: The second commit will be the addition of actual logging. The intention here is to be initially conservative; two immediate targets would be to replace calls to mail_admins() with logging calls, and replacing debug messages in management commands wi

Re: Logging in Django

2010-06-01 Thread Vinay Sajip
On Jun 1, 2:15 pm, Russell Keith-Magee wrote: > IMHO, that use case would be better handled with two different > settings files -- one with DEBUG=True and debug logging, and one with > DEBUG=False and production logging. Having multiple settings files > isn't an unusual deployment arrangement; th

Re: Logging in Django

2010-06-01 Thread Russell Keith-Magee
On Tue, Jun 1, 2010 at 3:14 PM, Vinay Sajip wrote: > > On Jun 1, 3:07 am, Russell Keith-Magee > wrote: >> >> My concern here is YAGNI. Can you suggest a specific use case where >> this will actually be required? > > I agree with the YAGNI principle generally, but to my mind it's > something to be

Re: Logging in Django

2010-06-01 Thread Vinay Sajip
On Jun 1, 3:07 am, Russell Keith-Magee wrote: > > My concern here is YAGNI. Can you suggest a specific use case where > this will actually be required? > I agree with the YAGNI principle generally, but to my mind it's something to bear in mind if one were implementing a new feature with a fair a

Re: Logging in Django

2010-05-31 Thread Russell Keith-Magee
On Sat, May 29, 2010 at 12:46 AM, Vinay Sajip wrote: > > On May 28, 4:48 pm, Russell Keith-Magee > wrote: >> Following some discussion at the DjangoCon.eu sprints, here's what >> we've got on the table regarding adding logging support to Django. >> >> The core of Vinay's work is essentially ready

Re: Logging in Django

2010-05-29 Thread Kevin howerton
I added a AdminEmailHandler to my branch and pulled the upstream changes. http://github.com/kevin/django-experimental/ It now behaves very close to how django-trunk does on exception ... by default there is a streamhandler pushing to stderr and the admin email handler pushing emails to admins. T

Re: Logging in Django

2010-05-29 Thread Kevin howerton
Well, that was just to demonstrate the point that you can have a really simple minimalist configuration if that's what you want... not that it's preferable or recommended or anything.. just that if you need/want simplicity in configuration it's there. Also, it won't end up in log/messages if that'

Re: Logging in Django

2010-05-28 Thread Vinay Sajip
On May 29, 1:05 am, Waylan Limberg wrote: > > Vinay has already stated that he is making his code (which is part of > python 2.7) available to be distributed with Django so it will work on > any version that Django works on. > Yes, I've develloped my Launchpad branch (which has the dictconfig cod

Re: Logging in Django

2010-05-28 Thread Vinay Sajip
On May 28, 10:27 pm, Kevin howerton wrote: > Indeed, though that config does exactly that with apache ... the > streamhandler by default spits everything out to stderr which is in > turn picked up by apache's logging. True, but your logging output's then interspersed with everything else that wr

Re: Logging in Django

2010-05-28 Thread Waylan Limberg
On Fri, May 28, 2010 at 4:39 PM, Mathieu Leduc-Hamel wrote: > Oh cool! next time I'll check in the PEP list before... > > But I don't understand how it'll work with older python version, like > the current 2.6 branch ? Vinay has already stated that he is making his code (which is part of python 2

Re: Logging in Django

2010-05-28 Thread Kevin howerton
"Yes, something like that is a fairly minimal configuration, but generally I've found a file-based log to be pretty much part of every site's requirement, for anything but the smallest (toy) site." Indeed, though that config does exactly that with apache ... the streamhandler by default spits ever

Re: Logging in Django

2010-05-28 Thread Mathieu Leduc-Hamel
Oh cool! next time I'll check in the PEP list before... But I don't understand how it'll work with older python version, like the current 2.6 branch ? On Fri, May 28, 2010 at 4:33 PM, Vinay Sajip wrote: > > On May 28, 9:16 pm, Mathieu Leduc-Hamel wrote: >> I would say, why not use the default p

Re: Logging in Django

2010-05-28 Thread Vinay Sajip
On May 28, 9:16 pm, Mathieu Leduc-Hamel wrote: > I would say, why not use the default python way to config logging, > handler and loggers ? it work fine and many projects are using it. > That way, we'll be able to use the same logging configuration for our > django projects and the different pyth

Re: Logging in Django

2010-05-28 Thread Vinay Sajip
On May 28, 8:55 pm, Kevin howerton wrote: > I see the utility of being able to have additional ways to setup the > logging, though as it is I think the biggest issue people have with > the logging stuff is that the dictconfig is already fairly > intimidating looking.  If someone really wants to di

Re: Logging in Django

2010-05-28 Thread Mathieu Leduc-Hamel
I would say, why not use the default python way to config logging, handler and loggers ? it work fine and many projects are using it. That way, we'll be able to use the same logging configuration for our django projects and the different python library that we may use and we the logging is implemen

Re: Logging in Django

2010-05-28 Thread Kevin howerton
I see the utility of being able to have additional ways to setup the logging, though as it is I think the biggest issue people have with the logging stuff is that the dictconfig is already fairly intimidating looking. If someone really wants to disable the default setup of logging, it should be as

Re: Logging in Django

2010-05-28 Thread Vinay Sajip
On May 28, 4:48 pm, Russell Keith-Magee wrote: > Following some discussion at the DjangoCon.eu sprints, here's what > we've got on the table regarding adding logging support to Django. > > The core of Vinay's work is essentially ready to go -- the logging > configuration code is an implementation

Re: Logging in Django

2010-05-28 Thread Jacob Kaplan-Moss
On Fri, May 28, 2010 at 5:48 PM, Russell Keith-Magee wrote: > So - comments? Suggestions? Just FTR, Russ and I have been talking about this for a few days here in Berlin, and I'm in agreement with this 100%. Jacob -- You received this message because you are subscribed to the Google Groups "D

Logging in Django

2010-05-28 Thread Russell Keith-Magee
Hi all, Following some discussion at the DjangoCon.eu sprints, here's what we've got on the table regarding adding logging support to Django. The core of Vinay's work is essentially ready to go -- the logging configuration code is an implementation of what has been accepted as a PEP, so there's n