Re: Logging format decision

2010-01-17 Thread Ivan Sagalaev
Russell Keith-Magee wrote: You've also defined a production server that uses just two loggers - exception and info - for the entire server. Again, this isn't especially realistic - in practice, you have a large number of fine grained loggers for different parts of the system. In fact, most of o

Re: Logging format decision

2010-01-17 Thread Russell Keith-Magee
On Sun, Jan 17, 2010 at 5:17 AM, Ivan Sagalaev wrote: > Russell Keith-Magee wrote: >> >> That said - I really do want to see logging in Django's trunk. If we >> can sort out the details in the background and get a good >> implementation ready, it could easily be the first feature committed >> for

Re: Logging format decision

2010-01-17 Thread Vinay Sajip
On Jan 16, 9:17 pm, Ivan Sagalaev wrote: > The main point that I'm trying to argue is that having handlers and > loggers *separate* is not needed in real world scenarios. If you want > your logging in several files you will have to define several handlers > and several loggers anyway. "Implicit ha

Re: Logging format decision

2010-01-16 Thread Ivan Sagalaev
Russell Keith-Magee wrote: That said - I really do want to see logging in Django's trunk. If we can sort out the details in the background and get a good implementation ready, it could easily be the first feature committed for v1.3. Agreed! I like Vinay's suggestion for exactly the reason you

Re: Logging format decision

2010-01-15 Thread Vinay Sajip
Further to my earlier post - I've put the whole branch on Launchpad: https://code.launchpad.net/~vinay-sajip/django/logging There's nothing much there at the moment, apart from some code as a proof of concept. Tested with the following code tacked on at the end of a vanilla settings.py: import l

Re: Logging format decision

2010-01-15 Thread Vinay Sajip
On Jan 15, 1:47 pm, Simon Willison wrote: > My biggest hangup with the logging implementation was figuring out > exactly when the logging configuration code should actually run. The > problem is that Django's startup execution order is poorly defined - > stuff relating to settings is lazily evalua

Re: Logging format decision

2010-01-15 Thread Vinay Sajip
On Jan 15, 1:47 pm, Simon Willison wrote: > On Jan 14, 1:57 am, Russell Keith-Magee > wrote: > > > The other issue that I think still needs to be addressed is the > > internal usage of logging by Django itself. > > My biggest hangup with the logging implementation was figuring out > exactly when

Re: Logging format decision

2010-01-15 Thread Simon Willison
On Jan 14, 1:57 am, Russell Keith-Magee wrote: > The other issue that I think still needs to be addressed is the > internal usage of logging by Django itself. My biggest hangup with the logging implementation was figuring out exactly when the logging configuration code should actually run. The pr

Re: Logging format decision

2010-01-13 Thread Russell Keith-Magee
On Sun, Jan 10, 2010 at 4:45 AM, Ivan Sagalaev wrote: > Hello everyone! > > There was a discussion here some time ago about logging in Django that led > to the ticket 12012 [1] where Simon has done most (all?) of the > implementation. > > There is still a disagreement on the format of the configur

Logging format decision

2010-01-09 Thread Ivan Sagalaev
Hello everyone! There was a discussion here some time ago about logging in Django that led to the ticket 12012 [1] where Simon has done most (all?) of the implementation. There is still a disagreement on the format of the configuration dict for it. Simon has implemented it from my ad-hoc pro