Re: Logging facility for Django

2007-04-24 Thread Andrew Durdin
On Apr 24, 12:23 am, Vinay Sajip <[EMAIL PROTECTED]> wrote: > > > I agree that thread locals would probably be ideal, but it looks like > > threading.local was only introduced in Python 2.4. To stay aligned > > with Django, it should really be 2.3 compatible. > > Fair point - I'd forgotten that th

Re: Logging facility for Django

2007-04-23 Thread Vinay Sajip
Hi Fraser, > > (a) Setting NOTSET on the root logger will cause absolutely everything > > to go through the logging system - this could be unnecessary overhead as > > well as being too much information. > > My reason for doing this was indeed to capture as much information as > possible and then

Re: Logging facility for Django

2007-04-23 Thread Fraser Nevett
Hi Vinay, Thanks for taking the time to review and provide feedback on this. Your explanation of how the logging module works and how it can be used was really helpful. > (a) Setting NOTSET on the root logger will cause absolutely everything > to go through the logging system - this could be unn

Re: Logging facility for Django

2007-04-23 Thread Vinay Sajip
Hi Fraser, Thanks for sharing this app with us. After a quick read through, I've some points on the initialising code in middleware.py: #== handler = ThreadBufferedHandler() handler.setLevel(logging.NOTSET) handler.setFormatter(logging.Formatter()) logging.

Re: Logging facility for Django

2007-04-23 Thread Fraser Nevett
Thanks for the feedback. Jeremy, what database backend are you using? On MySQL I don't see any SQL getting logged. I guess registering the handler to the root logger must mean it gets all the log information from the other loggers too. It's on my to-do list to add the ability to filter by logger

Re: Logging facility for Django

2007-04-22 Thread Malcolm Tredinnick
On Sun, 2007-04-22 at 20:28 +, Fraser Nevett wrote: > Hi All, > > I'm sure I'm not alone in using simple print statements to trace/log > what is going on in a Django app, especially when debugging. This > works OK when using runserver, but can be more difficult and > problematic to use with m

Re: Logging facility for Django

2007-04-22 Thread Jeremy Dunck
On 4/22/07, Fraser Nevett <[EMAIL PROTECTED]> wrote: ... > I'm sure I'm not alone in using simple print statements to trace/log Huzzah, you've knocked something off my to-do list. :) I've read the doc but not yet the code. My immediate feedback is that it'd be nice to have a convention of logg

Logging facility for Django

2007-04-22 Thread Fraser Nevett
Hi All, I'm sure I'm not alone in using simple print statements to trace/log what is going on in a Django app, especially when debugging. This works OK when using runserver, but can be more difficult and problematic to use with mod_python in a production environment. To try to give greater contr