Re: Improved labels for M2M relations

2020-11-03 Thread Julian Klotz
Hey there, thanks! I agree, "Relation between and " will work in all cases. Here’s a draft implementation: https://github.com/django/django/compare/master...julianklotz:feature_better_m2m_relation_labels Here’s what needs to be improved: - `create_many_to_many_intermediary_model`: The metho

Re: Improved labels for M2M relations

2020-11-02 Thread Adam Johnson
I don't think we can use just "Relation to" because M2M relationships are two-way by default. Whilst a ManyToManyField can be declared on one model, it adds a reverse field on the other model. We'd have to show both sides of the relation e.g. "Relation between and ". On Tue, 27 Oct 2020 at 08:56,

Re: Improved labels for M2M relations

2020-10-27 Thread Julian Klotz
… one last thought: The verbose name could be: “Media Item-Piece relation” The string presentation could be: “Relation to ”, e.g. “Relation to Piece xyz” Together: *Media Item-Piece relation: Relation to Piece xyz (ID: 11773)* Julian Klotz schrieb am Dienstag, 27. Oktober 2020 um 09:30:59 UTC+

Re: Improved labels for M2M relations

2020-10-27 Thread Julian Klotz
Hi Adam, thanks for picking this up so quickly. I considered setting custom “through” models to set verbose name and __str__, but I currently can’t “afford” changing all m2m fields throught the application. Here’s the feedback I got concerning the usability issues (e.g. for MediaItem_pieces_re

Re: Improved labels for M2M relations

2020-10-26 Thread Adam Johnson
Hi Julian It should be noted that you can improve the display today by creating explicit through models. However this is more longwinded. This change does look like a neat usability improvement to me. It can also help with debugging as the label appears in the default str/repr. My main question i

Improved labels for M2M relations

2020-10-26 Thread Julian Klotz
Hey there, here’s a little topic that impacts the usability of Django admin’s delete views. When deleting an object using django admin, you get a nice summary of all deleted objects. I really like the overview, but the labels used to describe m2m relations that will be deleted aren't user-fri