Re: Humanize naturaltime alternative phrasing

2018-06-06 Thread Adam Johnson
Claude, that's a good idea - it increases the future options and also doesn't require a lot of translation work up in Django core up front. On Sun, 3 Jun 2018 at 09:39, Claude Paroz wrote: > I think I'd rather do some refactoring so that creating its own filter > with custom strings is easier. >

Re: Humanize naturaltime alternative phrasing

2018-06-03 Thread Claude Paroz
I think I'd rather do some refactoring so that creating its own filter with custom strings is easier. I played a bit with the idea and obtained that: https://github.com/claudep/django/commit/b776f120f180 Claude -- You received this message because you are subscribed to the Google Groups "Djang

Re: Humanize naturaltime alternative phrasing

2018-06-02 Thread Greg
That's a great question. My guess would be that there is an equivalent in some languages but not all. It is tricky, though; French at least has both equivalent phrasings, but the localization is actually already using the phrasing that more closely matches "in five minutes." Some translations coul

Re: Humanize naturaltime alternative phrasing

2018-06-02 Thread Adam Johnson
Hi Gregory, I'm no expert on making changes to filters like this, but do you know what would the impact on translations be? Is there an equivalent alternative phrasing for all languages? FYI the tests are here: https://github.com/django/django/blob/78912ccd0e1fcdfe98ca85081c9eb8acb7aa1f6d/tests/h

Humanize naturaltime alternative phrasing

2018-06-01 Thread Gregory Kaleka
Django Humanize's naturaltime filter currently uses the phrasing "5 hours from now". In some contexts, I find the phrasing "in 5 hours" more natural. Here's a diff in the naturaltime definition that would allow this alternative phrasing as an option. Any thoughts from the community on this? Als