Re: FIleField(null=True) (Was: Guardrails around lack of model validation on blank=True fields)

2021-08-01 Thread Carlton Gibson
Hi Raffaele. Looking at #10244, it looks as if it needs someone to pick up Aymeric's suggestion. Would that be you? 😀 (Since you favour the option 2 there, I'd try that — it's probably OK with a suitable release note, as Aymeric said.) C. On Tuesday, 27 July 2021 at 23:46:33 UTC+2 Raffaele Sal

FIleField(null=True) (Was: Guardrails around lack of model validation on blank=True fields)

2021-07-27 Thread Raffaele Salmaso
Hi all, related to these tickets I want to remind this old ticket https://code.djangoproject.com/ticket/10244 which needs a decision. Thanks! On Sun, Jul 25, 2021 at 3:12 PM Jacob Walls wrote: > Hi group, > > We have several accepted tickets regarding developer headaches when a > blank=True fie

Re: Guardrails around lack of model validation on blank=True fields

2021-07-27 Thread Carlton Gibson
OK, super. Would you then fancy looking at that docs change? It does come up. It _is_ surprising that `blank` has this effect, and I'm not convinced it says clearly anywhere how you should approach it… Thanks for your efforts digging into this! 👍 C. On Tuesday, 27 July 2021 at 14:22:50 UTC+2

Re: Guardrails around lack of model validation on blank=True fields

2021-07-27 Thread Jacob Walls
This makes good sense, Carlton, and I didn't mean to be rushing your reply! "That way lies madness" is entirely correct. Just wanted to map the terrain after I had so confidently commented on one Trac ticket about wontfix-ing it, since on it there were various opinions about possible courses of

Re: Guardrails around lack of model validation on blank=True fields

2021-07-27 Thread Carlton Gibson
Hi Jacob. Thanks for the follow-up. Good hustle! 😉 I saw your comments on Trac last week, and was preparing a response. The trouble with these 8, 7, and 5 year old tickets is that they're tricky… Let me put the take-home first, I think that in-themselves we should close all three of these t

Guardrails around lack of model validation on blank=True fields

2021-07-25 Thread Jacob Walls
Hi group, We have several accepted tickets regarding developer headaches when a blank=True field, which skips model validation by design[1], contains inappropriate empty values (e.g. None for a not-nullable field or the empty string where empty strings aren't allowed). I want to see what the