Re: First ASGI pull request is ready for review

2019-05-01 Thread Andrew Godwin
This is quite unrelated to frontend - I'll explain more of the impact and potential impact in the DEP when I write it up. Andrew On Wed, 1 May 2019, 08:30 Elad Yaniv, wrote: > Exciting stuff! > does this mean that django 3.0 COULD compete with frontend js frameworks > ? (angular react vue) > i

Re: First ASGI pull request is ready for review

2019-05-01 Thread Elad Yaniv
Exciting stuff! does this mean that django 3.0 COULD compete with frontend js frameworks ? (angular react vue) if the answer is yes i will be a very happy developer Great work! Elad. On Wed, May 1, 2019 at 9:55 AM Carlton Gibson wrote: > Yes, I’ll review properly first half of next week. > >

Re: First ASGI pull request is ready for review

2019-04-30 Thread Carlton Gibson
Yes, I’ll review properly first half of next week. For the DEP, can you break out how and where people might input. There’s massive interest. 🙂 Great work as ever Andrew. Thank you so much! C. On Wed, 1 May 2019 at 08:46, Andrew Godwin wrote: > > > On Tue, Apr 30, 2019 at 11:34 PM Mariusz Fel

Re: First ASGI pull request is ready for review

2019-04-30 Thread Andrew Godwin
On Tue, Apr 30, 2019 at 11:34 PM Mariusz Felisiak < felisiak.mari...@gmail.com> wrote: > Thanks for this patch. Can you add a trac ticket? also Can you give me & > Carlton few days for review? I should be able to do this somewhere in the > next week. > I can indeed. I wasn't sure if you wanted to

Re: First ASGI pull request is ready for review

2019-04-30 Thread Mariusz Felisiak
Thanks for this patch. Can you add a trac ticket? also Can you give me & Carlton few days for review? I should be able to do this somewhere in the next week. Are we going to create "Async" DEP? Best, Mariusz -- You received this message because you are subscribed to the Google Groups "Djang

Re: First ASGI pull request is ready for review

2019-04-30 Thread Andrew Godwin
So, it looks like most of the comments on this PR have happened and been resolved - unless anyone has any objections, I will merge it in after a couple more days (just in time for PyCon US). Andrew On Wed, Apr 24, 2019 at 1:50 PM Andrew Godwin wrote: > Hi everyone, > > Just wanted to drop a not

Re: First ASGI pull request is ready for review

2019-04-24 Thread Curtis Maloney
I cannot find emoji enough to express how much I appreciate the work you've put into this :) -- Curtis On 4/25/19 6:50 AM, Andrew Godwin wrote: Hi everyone, Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review:

First ASGI pull request is ready for review

2019-04-24 Thread Andrew Godwin
Hi everyone, Just wanted to drop a note and say that the first pull request in the series needed to enable async in Django is now ready for review: https://github.com/django/django/pull/11209 This is a very minimal amount of work to get Django async-safe and understanding ASGI as an application i