Re: Filters no longer parsed for unresolved variables

2006-09-04 Thread Russell Keith-Magee
On 9/4/06, SmileyChris <[EMAIL PROTECTED]> wrote: I can't see that you've missed anything (but then again, I didn'tmanage to get it right on my attempt so don't trust me) ;)I've just committed the fix (along with some extra unit tests to make sure it stays fixed) as r3714. Thanks for the help in na

Re: Filters no longer parsed for unresolved variables

2006-09-03 Thread SmileyChris
Hi Russ, Thanks, that explains the problem with my patch perfectly :) Your solution looks great: it still solves the original problem while bringing back the correct functionality if TEMPLATE_STRING_IF_INVALID is not set. I can't see that you've missed anything (but then again, I didn't manage t

Re: Filters no longer parsed for unresolved variables

2006-09-01 Thread Russell Keith-Magee
On 9/1/06, SmileyChris <[EMAIL PROTECTED]> wrote: I believe the last line of that patch should have been:+obj = settings.TEMPLATE_STRING_IF_INVALIDbut I just wanted to check that the functionality change isn't intendedfirst. This was intentional; the original problem was that {% if

Re: Filters no longer parsed for unresolved variables

2006-08-31 Thread SmileyChris
Guess I should just make a ticket anyway: http://code.djangoproject.com/ticket/2637 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@g

Filters no longer parsed for unresolved variables

2006-08-31 Thread SmileyChris
Changeset [3268] made the following change for the resolve method in django/template/__init__.py: -obj = settings.TEMPLATE_STRING_IF_INVALID +if ignore_failures: +return None +else: +return settings.TEMPLATE_STRING_IF_INVALID Bec