Re: Feedback: Syndication feed views

2010-01-23 Thread Ben Firshman
Is it too late to sneak this in in as a minor feature? I have some time now, so I can write up some more documentation if it's needed. Ben On 4 Jan 2010, at 13:07, Ben Firshman wrote: > Is there any more documentation that I should write before the feature > freeze tomorrow? > > Thanks, > >

Re: Feedback: Syndication feed views

2010-01-04 Thread Ben Firshman
Is there any more documentation that I should write before the feature freeze tomorrow? Thanks, Ben On 22 Dec 2009, at 00:39, Ben Firshman wrote: > > On 21 Dec 2009, at 20:06, Luke Plant wrote: >>> I've documented it in some detail in the release notes. Is this >>> painstaking enough? >> >> U

Re: Feedback: Syndication feed views

2009-12-21 Thread Karen Tracey
> > (1) > http://code.djangoproject.com/attachment/ticket/12403/syndication-views-4.diff(Why > aren't my diffs showing? Are they too large for trac?) > > It's likely the six of these: \ No newline at end of file in the diff. Karen -- You received this message because you are subscribed to the

Re: Feedback: Syndication feed views

2009-12-21 Thread Ben Firshman
On 21 Dec 2009, at 20:06, Luke Plant wrote: >> I've documented it in some detail in the release notes. Is this >> painstaking enough? > > Unless I'm missing something, it's not nearly there (but some of this > may be the 'formal stuff' that Jacob doesn't mind being missing for > now). > > Firs

Re: Feedback: Syndication feed views

2009-12-21 Thread Luke Plant
On Monday 21 December 2009 17:20:33 Ben Firshman wrote: > > * What is going to happen to feeds.Feed? Is it deprecated or > > not? (there is no PendingDeprecationWarning AFAICS). > > I for one have a lot of code that uses feeds.Feed directly, > > bypassing the 'high level' framework that provide

Re: Feedback: Syndication feed views

2009-12-21 Thread Ben Firshman
On 21 Dec 2009, at 12:29, Luke Plant wrote: > On Sunday 20 December 2009 13:04:00 Ben Firshman wrote: >> Okay, I've updated the ticket with a new patch: >> >> http://code.djangoproject.com/ticket/12403 >> >> I wasn't sure on the extent of the depreciation warnings required, >> but hopefully that's

Re: Feedback: Syndication feed views

2009-12-21 Thread Luke Plant
On Sunday 20 December 2009 13:04:00 Ben Firshman wrote: > Okay, I've updated the ticket with a new patch: > > http://code.djangoproject.com/ticket/12403 > > I wasn't sure on the extent of the depreciation warnings required, > but hopefully that's the sort of thing needed. > > Thanks, > > Ben

Re: Feedback: Syndication feed views

2009-12-20 Thread Ben Firshman
Okay, I've updated the ticket with a new patch: http://code.djangoproject.com/ticket/12403 I wasn't sure on the extent of the depreciation warnings required, but hopefully that's the sort of thing needed. Thanks, Ben On 20 Dec 2009, at 12:15, Ben Firshman wrote: > Oops, looks like I used the

Re: Feedback: Syndication feed views

2009-12-20 Thread Ben Firshman
Oops, looks like I used the wrong git diff command and it didn't include any new files. I'll have a stab at the depreciation warnings too. Ben On 20 Dec 2009, at 02:49, Jacob Kaplan-Moss wrote: > On Sat, Dec 19, 2009 at 8:33 AM, Jacob Kaplan-Moss wrote: >> Code-wise, though, everything looks f

Re: Feedback: Syndication feed views

2009-12-19 Thread Jacob Kaplan-Moss
On Sat, Dec 19, 2009 at 8:33 AM, Jacob Kaplan-Moss wrote: > Code-wise, though, everything looks fine. Don't worry too much about > getting to all the formal stuff: I'll probably be committing this > today. Or not. There's a failing test in your patch:: ===

Re: Feedback: Syndication feed views

2009-12-19 Thread Jacob Kaplan-Moss
On Fri, Dec 18, 2009 at 2:38 PM, Ben Firshman wrote: > Patch and ticket done. Any comments? It's looking pretty perfect to me. The only things I can see missing are the various formal bits of deprecating the old and documenting the new: you need deprecation warnings, notes in the deprecation sche

Re: Feedback: Syndication feed views

2009-12-18 Thread Ben Firshman
Patch and ticket done. Any comments? http://code.djangoproject.com/ticket/12403 Thanks, Ben On 17 Dec 2009, at 10:06, Ben Firshman wrote: > I've made a few more changes, added many more tests and written > documentation. This now fixes #6188, #6304, #6618, #6969, #8758, > #8989, #10334, #1

Re: Feedback: Syndication feed views

2009-12-17 Thread Ben Firshman
I've made a few more changes, added many more tests and written documentation. This now fixes #6188, #6304, #6618, #6969, #8758, #8989, #10334, #11069 and #11973. Any final feedback would be appreciated. I'll put it together as a patch and put it in a ticket as soon as possible. Thanks, Be

Feedback: Syndication feed views

2009-11-28 Thread Ben Firshman
Hi all, I originally had great plans for refactoring the syndication contrib app, but a lack of time and the thorny issue of backwards compatibility has forced me to stick to the one big feature: making feeds class-based views. http://github.com/bfirsh/syndication-view/ The readme should be se