Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread koenb
Hey Mike, > To use Koen's example, he has not implement regex lookups yet, and he wishes > to tell the test not to fail as it simply not implemented. In my opinion the > test SHOULD fail because well the test is to see whether or not this feature > is implement, and its not. Now i'm not familiar

Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread Michael Radziej
Hi, On Thu, Sep 13, Russell Keith-Magee wrote: > Regarding the implementation - I'm sure the easiest solution will be > to put an 'if not mysql' check around the failing tests. However, my > preferred solution would fix this at the output layer, rather than the > test layer - i.e., let the tests

Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread Michael Scott
Hey everyone, I've been keeping an eye on the list for a little while now, and felt I was ready to add in my thoughts. In regard to this implementation I think care has to be taken that the option not be presented as a coders easy way out so-to-speak, the issue being that this implementation coul

Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread koenb
I am having a similar problem with a custom db2 backend I am working on too. Maybe it can be linked in the implementation to some backend flag (in the backends DatabaseFeatures) stating that deferred constraint checking is not (entirely) implemented ? This as opposed to hardcoding "mysql" in the t

Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread Russell Keith-Magee
On 9/13/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > > So, I'd appeal for skipping tests that cannot succeed, like in this > case. This is ticket #4788, and it has been accepted as an idea. We just need an implementation. If you want this for a sprint activity, it's all yours. Regarding the

Re: Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread Russell Keith-Magee
On 9/13/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > > So, I'd appeal for skipping tests that cannot succeed, like in this > case. This is ticket #4788, and it has been accepted as an idea. We just need an implementation. If you want this for a sprint activity, it's all yours. Regarding the

Failing tests for fixtures with MySQL (#5399)

2007-09-13 Thread Michael Radziej
Hi, we know that the tests for fixtures fail for MySQL (innodb) since MySQL checks foreign key constraints too early. OK. But how do we deal with the testsuite? I'd like that the tests always succeed for any database backend (unless something is broken in the code or in the installation that ne