Re: Failing silently, and documentation thereof

2006-01-12 Thread Eugene Lazutkin
Simon Willison wrote: We really need an official Django logging framework so stuff like this can be logged (rather than the current email-to-admins workaround which doesn't scale to large deployments). Semi-related note: I really like current js-enabled error reports, which are produced wi

Re: Failing silently, and documentation thereof

2006-01-12 Thread Radek Svarz
>> We really need an official Django logging frameworkIf you consider adding logging module into Django, take a look at keyword based logging. http://agiletesting.blogspot.com/2005/06/keyword-based-logging-with-py-library.htmlRadekOn 1/12/06, Simon Willison <[EMAIL PROTECTED]> wrote:On 12 Jan 20

Re: Failing silently, and documentation thereof

2006-01-12 Thread Amit Upadhyay
On 1/12/06, Simon Willison <[EMAIL PROTECTED]> wrote: On 12 Jan 2006, at 06:59, James Bennett wrote:> The Django docs say that template filters should always fail silently> and never raise exceptions; they should instead return either the> original input or an empty string, as appropriate. And when

Re: Failing silently, and documentation thereof

2006-01-12 Thread James Bennett
On 1/12/06, Simon Willison <[EMAIL PROTECTED]> wrote: > Thinking about this further, it could result in a security hole. If a > filter that removes dangerous markup failed silently and that markup > was spewed on to a page it could lead to an XSS vulnerability. I would hope that the author of suc

Re: Failing silently, and documentation thereof

2006-01-12 Thread Simon Willison
On 12 Jan 2006, at 06:59, James Bennett wrote: The Django docs say that template filters should always fail silently and never raise exceptions; they should instead return either the original input or an empty string, as appropriate. And when writing template tags, the tag's render() method sh

Failing silently, and documentation thereof

2006-01-11 Thread James Bennett
In the IRC channel tonight there was some discussion (mostly motivated by ticket #1204) about template tags and filters failing silently, particularly those in the markup app. Since it was kind of late and people were popping in and out it sputtered, but I think it's an interesting topic to bring