Re: Dynamic inlines for Django ModelAdmin

2015-07-27 Thread Gert Steyn
> > While the request per se makes sense I have the feeling that the admin is > becoming a dumping ground for every possible method out there :/ > We have six views squeezed into a single class, making it customizable will inevitably require a large number of methods. My prediction is that it

Re: Dynamic inlines for Django ModelAdmin

2015-07-27 Thread Florian Apolloner
I always add all classes and then use get_inline_instances to filter it. While the request per se makes sense I have the feeling that the admin is becoming a dumping ground for every possible method out there :/ On Monday, July 27, 2015 at 10:03:59 AM UTC+2, Shai Berger wrote: > > On Monday 27 J

Re: Dynamic inlines for Django ModelAdmin

2015-07-27 Thread Gert Steyn
Duplicating an entire method from core is the easy part, remembering to check that against the new Django code every time there is a new Django release is the actual problem. Gert > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributi

Re: Dynamic inlines for Django ModelAdmin

2015-07-27 Thread Shai Berger
On Monday 27 July 2015 10:57:41 Florian Apolloner wrote: > Doesn't get_inline_instances > (https://github.com/django/django/blob/master/django/contrib/admin/options. > py#L520) do exactly that? > The request, as far as i understand, is to have the list of inline classes be determined dynamically

Re: Dynamic inlines for Django ModelAdmin

2015-07-27 Thread Florian Apolloner
Doesn't get_inline_instances (https://github.com/django/django/blob/master/django/contrib/admin/options.py#L520) do exactly that? Cheers, Florian On Monday, July 27, 2015 at 7:33:58 AM UTC+2, Gert Steyn wrote: > > Hi All > > I've been using Django since before newforms-admin and have seen > M

Dynamic inlines for Django ModelAdmin

2015-07-26 Thread Gert Steyn
Hi All I've been using Django since before newforms-admin and have seen ModelAdmin gradually becoming more customization. I often use dynamic inlines (based on the state of the object) and would like to clean up the implementation a bit. I would like to open a ticket to add: def get_inlines(s