Re: Duplicated joins on kwarg queries over related tables

2005-12-29 Thread Adrian Holovaty
On 12/29/05, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > I've just submitted Ticket #1136 that removes table join duplication. Enjoy. Thanks, Russ! Excellent work. I've applied your patch in the magic-removal branch. Adrian -- Adrian Holovaty holovaty.com | djangoproject.com | chicagocrime

Re: Duplicated joins on kwarg queries over related tables

2005-12-29 Thread Russell Keith-Magee
On 12/29/05, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > I remember there being a good reason for this, but I don't recall the > exact reason at this point... :-( > > At any rate, feel free to play around with a patch (and some > accompanying unit tests) to see whether you can remove the > table-

Re: Duplicated joins on kwarg queries over related tables

2005-12-29 Thread Adrian Holovaty
On 12/27/05, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Is there any reason that once a table has been joined into a query, it > isn't reused? As far as I can work out, this would also remove the need > for the table_count/params to produce unique table aliases (since if a > table is only na

Duplicated joins on kwarg queries over related tables

2005-12-27 Thread Russell Keith-Magee
Hi, DB kwarg queries can traverse many-many and many-one relationships; if this is done, the parse_lookup function works out the required table, and constructs a join and where clause as required. However, if a query contains two queries over the same relationship, the secondary table will be jo