Re: Django Admin New Look

2017-12-10 Thread Roberth Solis Martínez
Huuum it sounds cool El martes, 17 de noviembre de 2015, 9:04:48 (UTC-6), Fabio Caccamo escribió: > > Hi guys, > I just released https://github.com/fabiocaccamo/django-admin-interface > > It is based on the great Elky's theme, but by default it uses the same > colors of https://www.djangoproject

Re: Django Admin New Look

2015-11-17 Thread Fabio Caccamo
Hi guys, I just released https://github.com/fabiocaccamo/django-admin-interface It is based on the great Elky's theme, but by default it uses the same colors of https://www.djangoproject.com/ and as a plus it allows some interface customizations (title, logo and colors) directly through the ad

Re: Django Admin New Look

2015-09-04 Thread elky
Thanks for clarification, Collin. On Friday, 4 September 2015 17:38:05 UTC+5, Collin Anderson wrote: > > That looks right to me. More specifically (from the attic/magic-removal > branch): > Added css and some of those html classes: > > https://github.com/django/django/commit/84b7590ba6e566186bba9

Re: Django Admin New Look

2015-09-04 Thread Collin Anderson
That looks right to me. More specifically (from the attic/magic-removal branch): Added css and some of those html classes: https://github.com/django/django/commit/84b7590ba6e566186bba975e57b0686dd53927ca Removed html classes, but not css: https://github.com/django/django/commit/738d9af1e8e38b0289b7

Re: Django Admin New Look

2015-09-04 Thread elky
Does anybody know where this CSS code (https://github.com/elky/django/commit/36c1decd2f18c3af947546ea3b8eaeaecd2762ba) uses? I didn't find any mention of these CSS classes in the project. The first mention of these styles came from this 9 years old commit - https://github.com/django/django/co

Re: Django Admin New Look

2015-08-29 Thread Tim Graham
It seems like a nice idea if the implementation is simple. On Friday, August 28, 2015 at 9:11:27 AM UTC-4, Nick Sarbicki wrote: > > This takes the conversation back a ways... > > But I like the idea of being able to customise the admin scheme. Enforce a > default of course, but maybe have some op

Re: Django Admin New Look

2015-08-28 Thread Nick Sarbicki
This takes the conversation back a ways... But I like the idea of being able to customise the admin scheme. Enforce a default of course, but maybe have some options (in admin.py? or as a separate script?) which can change the core colors of the scheme, either a set of predefined colours, or som

Re: Django Admin New Look

2015-08-27 Thread Tim Graham
Carl pinged me in #django-dev to say that the technical board says it's ok to go ahead with dropping IE8 support in admin for 1.9. Three +1s and two +0s. The +0s were due to feeling that: a) IE isn't as dead as in some places as it is in the Valley b) the advantages gained by dropping support are

Re: Django Admin New Look

2015-08-21 Thread 'Hugo Osvaldo Barrera' via Django developers (Contributions to Django itself)
On Fri, Aug 21, 2015, at 08:06, elky wrote: > Does 'title' attribute help in terms of accessibility? `title` adds a tooltip, so no, not really. -- Hugo Osvaldo Barrera -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django i

Re: Django Admin New Look

2015-08-21 Thread elky
Does 'title' attribute help in terms of accessibility? On Friday, 21 August 2015 14:44:02 UTC+5, Hugo Osvaldo Barrera wrote: > > > I see not mention of this later on this thread so I have to ask: > Do we have an equivalent of an `alt` if using fonts? If not, how would > this be usable by, for

Re: Django Admin New Look

2015-08-21 Thread 'Hugo Osvaldo Barrera' via Django developers (Contributions to Django itself)
On Sun, Aug 16, 2015, at 16:00, elky wrote: > Hi guys, > > I made double work for vector icons - now we have Font and SVG icons. > Let's choose what to use. > > *Quoting my comment[1] from SVG discussion here:* > >> Well, only week ago I was 100% happy with font icons. But after >> Collin's comme

Re: Django Admin New Look

2015-08-20 Thread Tim Graham
Thanks everyone for feedback. I think it's a good idea to send this to the technical board to reach a consensus. Here is the summary as I see it: Benefits of jQuery 2: * Smaller file size (36KB or 11KB for minified version) * "Faster" -- not sure this has any practical benefit currently, but migh

Re: Django Admin New Look

2015-08-20 Thread Collin Anderson
To be clear: jQuery 1.x and 2.x are the exact same except for IE < 9 compatibility. jQuery v1.11.3 and v2.1.4, released simultaneously, _are_ the latest version of jQuery. It's not like "1.11.x" is an "old" release series. 1.x and 2.x have the exact same features and API and are 100% compatible

Re: Django Admin New Look

2015-08-20 Thread Aymeric Augustin
2015-08-20 16:14 GMT+02:00 Tom Christie : > Could we give users guidance on overriding the admin's application > specific static files with global static files if we do this? > The general rule is: if several applications provide the same resource, the earliest application in INSTALLED_APPS wins.

Re: Django Admin New Look

2015-08-20 Thread Tom Christie
Could we give users guidance on overriding the admin's application specific static files with global static files if we do this? Not immediately clear to me what order static files are copied in, but presumably it's possible to ensure that the jquery static files included in the admin app direc

Re: Django Admin New Look

2015-08-20 Thread Josh Smeaton
The only reason that I'm on the fence about not actively ending IE8 support right now is that it will still be in support for the release of Django 1.9. It'll only be a month, but it's something. I'd feel more comfortable about a soft deprecation now and a harder end for Django 1.10. It'll at l

Re: Django Admin New Look

2015-08-20 Thread Marc Tamlyn
I think this is a bit of a misnomer - if we include a jQuery without IE8 support we will start dropping IE8 from the CSS, our own custom javascript, new jquery features, community plugins will drop it etc etc. For 1.9 itself it may simply be a case of swapping in a different jQuery version, but it

Re: Django Admin New Look

2015-08-19 Thread Josh Smeaton
>My own opinion is that if you really need IE8 support, it's not difficult to write a custom template and conditionally include the old jQuery version. Good point. It's easy enough for users to support IE8 themselves if they need to. Consider me a +1 then. On Thursday, 20 August 2015 00:34:01 U

Re: Django Admin New Look

2015-08-19 Thread Marc Tamlyn
FWIW, I can see the arguments here and I would definitely like to move to jquery 2 and drop old browsers (aggressively). Actually having a solid browser support policy, a redesign etc would be a great time to do this as well. I can see we are likely to get some backlash, but maybe less than I thin

Re: Django Admin New Look

2015-08-19 Thread Tim Graham
To see what's required, I made a pull request for jQuery 2 here: https://github.com/django/django/pull/5155 The selenium and JavaScript tests pass without any modifications to the admin's JavaScript. My own opinion is that if you really need IE8 support, it's not difficult to write a custom t

Re: Django Admin New Look

2015-08-19 Thread Sam Cooke
I meant jQuery 2 and 1.11 are API compatible - you're right though, the latest versions of jQuery might have deprecated things that are currently used in Django. On Wed, 19 Aug 2015 at 10:39 elky wrote: > > On Wednesday, 19 August 2015 14:27:53 UTC+5, sdcooke wrote: >> >> and get the performance

Re: Django Admin New Look

2015-08-19 Thread elky
On Wednesday, 19 August 2015 14:27:53 UTC+5, sdcooke wrote: > > and get the performance boost of jQuery 2 in modern browsers. As far as > I'm aware they are still API compatible. > We should carefully check jQuery change log. I remember they removed toggle method in one of the latest versions,

Re: Django Admin New Look

2015-08-19 Thread Sam Cooke
For jQuery support in older browsers it's pretty simple to include jQuery 1.11 in old IE using conditional comments - that way we retain support with just an extra line of code, don't leave IE8 behind, and get the performance boost of jQuery 2 in modern browsers. As far as I'm aware they are still

Re: Django Admin New Look

2015-08-19 Thread Josh Smeaton
I agree with Shai. There are certain companies that have bought extended support for WinXP/IE8 for extravagant amounts of money. That means Microsoft is taking on the burden of support (security) for those systems. They are EOL as far as we're concerned. We shouldn't intentionally cripple suppo

Re: Django Admin New Look

2015-08-18 Thread Shai Berger
On Tuesday 18 August 2015 14:29:15 Marc Tamlyn wrote: > I don't know about schedule, but caniuse reports IE8 browser usage at 1.5%, > more than IE9 or IE10. > > There's an argument we shouldn't be "enabling" people still using XP who > are stuck on IE8, and this is a decreasing problem, but I don'

Re: Django Admin New Look

2015-08-18 Thread Markus Holtermann
Hey, Looking at some browser market share stats (http://www.sitepoint.com/browser-trends-august-2015-chrome-exceeds-50/ , disclaimer: http://www.sitepoint.com/how-browser-market-share-is-calculated/) IE8 seems hardly be used anyway. Furthermore, with the dropped support for IE8 (and 9+) on Jan 12

Re: Django Admin New Look

2015-08-18 Thread Marc Tamlyn
I don't know about schedule, but caniuse reports IE8 browser usage at 1.5%, more than IE9 or IE10. There's an argument we shouldn't be "enabling" people still using XP who are stuck on IE8, and this is a decreasing problem, but I don't think we can tie ourselves to Microsoft's support dates. On 1

Re: Django Admin New Look

2015-08-18 Thread Tim Graham
I also had the idea of upgrading jQuery to jQuery 2 which drops support for IE6/7/8, but I guess this will break all the JavaScript in the admin under those browsers. Do you think that's unacceptable at this time? If so, could you propose an alternate timetable for the upgrade? On Tuesday, Augu

Re: Django Admin New Look

2015-08-18 Thread Aymeric Augustin
On 18 août 2015, at 01:28, Tim Graham wrote: > Unless someone can present an argument for keeping IE8 support, I wouldn't > worry about it considering it will be end of life about 1 month after the > release of Django 1.9. Let’s just make sure the admin stays usable, even if it looks bad. Sinc

Re: Django Admin New Look

2015-08-17 Thread Tim Graham
The SVG option looks good to me as well. While you are there, could you update the "no" icon as done in https://github.com/elky/django-flat-theme/pull/14? Unless someone can present an argument for keeping IE8 support, I wouldn't worry about it considering it will be end of life about 1 month a

Re: Django Admin New Look

2015-08-17 Thread Marc Tamlyn
+1 to the svg option. On 16 August 2015 at 20:00, elky wrote: > Hi guys, > > I made double work for vector icons - now we have Font and SVG icons. > Let's choose what to use. > > *Quoting my comment > from SVG > discussion here:* > > Well,

Re: Django Admin New Look

2015-08-16 Thread elky
Hi guys, I made double work for vector icons - now we have Font and SVG icons. Let's choose what to use. *Quoting my comment from SVG discussion here:* Well, only week ago I was 100% happy with font icons. But after Collin's commen

Re: Django Admin New Look

2015-08-07 Thread elky
Just posted a comment regarding inline SVG here: https://code.djangoproject.com/ticket/20597#comment:12 If everyone is fine with Font Awesome - I'm going to create pull request in master. -- You received this message because you are subscribed to the Google Groups "Django developers (Contrib

Re: Django Admin New Look

2015-07-30 Thread Aymeric Augustin
I am wary of privacy implications (leaking referers) of making it too easy to use a CDN, all the more since the admin is lightweight and not performance-critical. -- Aymeric. > Le 30 juil. 2015 à 11:05, Marc Tamlyn a écrit : > > One thing that might be nice to do with the admin, especially i

Re: Django Admin New Look

2015-07-30 Thread Marc Tamlyn
One thing that might be nice to do with the admin, especially in the context of the fonts but also with jQuery, is to give an easy override to use CDN versions of the files. Django still needs to bundle them for offline work, and the default should be to include Django's own ones, but it would be g

Re: Django Admin New Look

2015-07-30 Thread Aymeric Augustin
Le 29 juil. 2015 à 13:13, elky a écrit : > > I can create small kit which will contain only icons that used in the project > - it will allow us to save about 70KB. But the question is - how to support > this kit in future if someone decide to add new icons ? Indeed, it could be difficult to ma

Re: Django Admin New Look

2015-07-29 Thread Andy Baker
I do a lot of projects with highly customized admins and having the full font awesome would be splendid. One option is to use optional requirements: pip install django[all-icons] but I don't think Django does this anywhere else so it's probably a big leap for a small part of contrib.admin Maybe

Re: Django Admin New Look

2015-07-29 Thread Tim Graham
In https://code.djangoproject.com/ticket/20597 we discussed switching to SVG (instead of an icon font) in Django 1.10 when we can drop support for IE8. Now that Django 1.9 is slated for December and IE8 support ends the next month, I think it might be acceptable to drop IE8 support in 1.9 and g

Re: Django Admin New Look

2015-07-29 Thread Marc Tamlyn
Font Awesome is not GPL - the code is MIT and the font itself is SIL OFL both of which are fine to include with Django. On 29 July 2015 at 12:13, elky wrote: > Hi guys, > > I'm glad to say I finished work on replacing image icons with font. I used > Font > Awesome

Re: Django Admin New Look

2015-07-29 Thread elky
Hi guys, I'm glad to say I finished work on replacing image icons with font. I used Font Awesome (GPL licence) kit to do it. I'll appreciate if you test new icons in your project and report any issues here

Re: Django Admin New Look

2015-05-30 Thread Emil Stenström
I just wanted to add that this looks GREAT. Maintaining the old colors was a smart move, as this makes things familiar but still new. This work was long overdue! /E On Saturday, 23 May 2015 14:00:18 UTC+2, elky wrote: > > HI Andy, > > Yes, this thread is actual for discussing this theme. > > Cu

Re: Django Admin New Look

2015-05-23 Thread elky
HI Andy, Yes, this thread is actual for discussing this theme. Current pull request is https://github.com/django/django/pull/4627 I hope I'll have enough time to work on it this weekend. On Saturday, 23 May 2015 15:35:51 UTC+5, Andy Baker wrote: > > Hi, > > Is this thread still the most up to

Re: Django Admin New Look

2015-05-23 Thread Andy Baker
Hi, Is this thread still the most up to date place for discussing this? I'm trying to work out what the current status is and whether it is likely to land in 1.9. For the benefit of anyone else coming to this late here's what I can track down: Last comment here prior to mine was jezdez on Apr

Re: Django Admin New Look

2015-04-14 Thread Jannis Leidel
> On 07 Apr 2015, at 18:15, Aymeric Augustin > wrote: > > 2015-04-07 17:25 GMT+02:00 Marc Tamlyn : > The primary questions to establish answers to before a possible merge in my > opinion are: > - Do we ship both, or just the new one and release the old one as a third > party package? > > I'd

Re: Django Admin New Look

2015-04-07 Thread Aymeric Augustin
2015-04-07 17:25 GMT+02:00 Marc Tamlyn : > The primary questions to establish answers to before a possible merge in > my opinion are: > - Do we ship both, or just the new one and release the old one as a third > party package? > I'd like to make the new theme the default unless the developer opts

Re: Django Admin New Look

2015-04-07 Thread Marc Tamlyn
We would modify our base admin template when we merge it. There are a number of third party applications which provide modified versions of their admin pages (FeinCMS is a good example of a moderately complex one). They would normally support two versions of Django (maybe also an LTS now), and so w

Re: Django Admin New Look

2015-04-07 Thread elky
On Tuesday, 7 April 2015 20:23:28 UTC+5, Collin Anderson wrote: > > There's a ticket about icons here: > https://code.djangoproject.com/ticket/20597 > Thanks Collin. On Tuesday, 7 April 2015 20:25:57 UTC+5, Marc Tamlyn wrote: > > The primary questions to establish answers to before a possible

Re: Django Admin New Look

2015-04-07 Thread Marc Tamlyn
Django's master is the correct branch for 1.9 development now. Flat icons would be good, and I agree personally with your earlier suggestion to use font awesome icons. I do think this is a separate issue we could add later. The primary questions to establish answers to before a possible merge in

Re: Django Admin New Look

2015-04-07 Thread Collin Anderson
There's a ticket about icons here: https://code.djangoproject.com/ticket/20597 On Tuesday, April 7, 2015 at 11:16:42 AM UTC-4, elky wrote: > > Hi everyone. As you can see there is less activity now in this thread. > With the latest 0.9.3 release I just think CSS work is over until anyone > repo

Re: Django Admin New Look

2015-04-07 Thread elky
Hi everyone. As you can see there is less activity now in this thread. With the latest 0.9.3 release I just think CSS work is over until anyone report a bug or suggestion to improvement. There is big interest from the community: - 1736 downloads in the last month from PyPi

Re: Django Admin New Look

2015-03-19 Thread elky
django-flat-theme is available on pypi now: https://pypi.python.org/pypi/django-flat-theme On Wednesday, 18 March 2015 23:53:04 UTC+5, elky wrote: > > Yeah, I'm planning to publish this app on pypi this week > > -- You received this message because you are subscribed to the Google Groups "Djan

Re: Django Admin New Look

2015-03-18 Thread elky
Yeah, I'm planning to publish this app on pypi this week On Wednesday, 18 March 2015 23:41:33 UTC+5, Ryan Hiebert wrote: > > In the likely event that it won’t be back ported to 1.8, can you release > it on PyPI? Actually, you may wish to do that anyway for older versions. > > I use setup.py to in

Re: Django Admin New Look

2015-03-18 Thread Ryan Hiebert
In the likely event that it won’t be back ported to 1.8, can you release it on PyPI? Actually, you may wish to do that anyway for older versions. I use setup.py to install my django app, so it’s difficult to add direct github url dependencies. (It takes a flag when installing with pip, which isn

Re: Django Admin New Look

2015-03-18 Thread elky
Awesome!! Sounds fantastic. Thanks, Aymeric On Monday, 16 March 2015 22:24:39 UTC+5, Aymeric Augustin wrote: > > For what it's worth, I've deployed your theme on an internal application > and received positive feedback from users. I don't receive feedback often, > let alone positive feedback. >

Re: Django Admin New Look

2015-03-16 Thread Aymeric Augustin
2015-03-16 15:41 GMT+01:00 elky : > I'm going to make pull request this week, so in case of success I hope > people will have enough time to test new theme in alpha and beta releases. > For what it's worth, I've deployed your theme on an internal application and received positive feedback from us

Re: Django Admin New Look

2015-03-16 Thread elky
As far as I remember the main argument of that suggestion was third-party apps will be broken in terms of color scheme (this was in green-theme discussion). But now we have new look with same colors as default admin. So I don't think we need additional setting to switch themes - primarily becau

Re: Django Admin New Look

2015-03-16 Thread Tim Graham
In some previous discussion, it was suggested to have a toggle between the new and old designs to ease the transition. I guess this could be something like a "theme" attribute on AdminSite. Do you think this is required? It seems this could be a non-trivial maintenance burden if we have to test

Re: Django Admin New Look

2015-03-13 Thread elky
> > Did you test RTL? > > I did. I tested Arabic and Hebrew - no issues detected for me. BUT. As far > as I understand Django admin has poor RTL support by itself. > Sorry guys, I was wrong about it. Django has very good RTL support! Just didn't notice right setting to test it. But anyway I did

Re: Django Admin New Look

2015-03-13 Thread elky
> > In line with that, how does it perform for mobile devices? > Same as default django admin. I don't plan to make admin responsive yet (to make it perfectly accessible on mobile) - just because we can't control third-party apps. Ideally django should have its own css framework for that but n

Re: Django Admin New Look

2015-03-12 Thread Florian Apolloner
First off, great work Alex! On Thursday, March 12, 2015 at 11:31:32 AM UTC+1, elky wrote: > > Yes, I tested this theme on real project which is big and complex. But I'm > not 100% sure that I saw all cases. I think we need more user's feedback on > it. > You could create a project with a few mo

Re: Django Admin New Look

2015-03-12 Thread Tom Christie
Amazing work so far. :) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To

Re: Django Admin New Look

2015-03-12 Thread Jonhnatha J. R. Trigueiro
Hi Alexey, I started using it on my project. Awesome. Clean and beautiful interface. Thank You! 2015-03-12 7:30 GMT-03:00 Alexey : > Thanks you Aymeric > > On 12 March 2015 at 03:02, Aymeric Augustin < > aymeric.augus...@polytechnique.org> wrote: > > Now let's try and see if we can merge it :-)

Re: Django Admin New Look

2015-03-12 Thread elky
Thanks you Aymeric Now let's try and see if we can merge it :-) Nice to hear :) But I think there's no rush and we need more testing and more feedback. I'm not sure how people will feel about shipping 320kB of fonts with Django We can reduce fonts size by 160kB I believe. I used 4 font weights

Re: Django Admin New Look

2015-03-12 Thread Alexey
Thanks you Aymeric On 12 March 2015 at 03:02, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: Now let's try and see if we can merge it :-) > Nice to hear :) But I think there's no rush and we need more testing and more feedback. I'm not sure how people will feel about shipping 32

Re: Django Admin New Look

2015-03-11 Thread Aaron C. de Bruyn
Beautiful. It's clean and simple. Great work! -A On Wed, Mar 11, 2015 at 1:20 PM, elky wrote: > Hi everyone, > > I reworked my previous attempt of stylizing django admin and now it looks > more like original in terms of color scheme. See attachments. > > For those who want to play with new the

Re: Django Admin New Look

2015-03-11 Thread Aymeric Augustin
2015-03-11 21:20 GMT+01:00 elky : > I reworked my previous attempt > of stylizing django admin > and now it looks more like original in terms of color scheme. See > attachments. > This looks good! Now let's try and see if we can merge it :-) Here are

Re: Django Admin New Look

2015-03-11 Thread Thomas Rega
+1 Am 11.03.2015 21:20 schrieb "elky" : > Hi everyone, > > I reworked my previous attempt > of stylizing django admin > and now it looks more like original in terms of color scheme. See > attachments. > > For those who want to play with new theme I cre

Re: Django Admin New Look

2015-03-11 Thread Collin Anderson
That looks beautiful! I can see all of the improvement from last time too! I'd personally prefer slightly less vertical padding, but otherwise I think it's awesome! Thanks! Collin On Wednesday, March 11, 2015 at 4:20:31 PM UTC-4, elky wrote: > > Hi everyone, > > I reworked my previous attempt

Re: Django Admin New Look

2015-03-11 Thread Bruno Ribeiro da Silva
Looks good! Congrats! On Wed, Mar 11, 2015 at 5:20 PM, elky wrote: > Hi everyone, > > I reworked my previous attempt > of stylizing django admin > and now it looks more like original in terms of color scheme. See > attachments. > > For those who want

Django Admin new look

2015-03-06 Thread Ryan Allen
These look very nice and are a step in the right direction. If you only overrode admin/css/base.css I see no reason why this change can't be made. Hanging on to the old design for legacy purposes has gone on long enough, it's time to update. I would make a pull request after ensuring the new des

Re: Django Admin new look

2015-03-04 Thread Riccardo Magliocchetti
Il 05/03/2015 00:37, Curtis Maloney ha scritto: Looks pretty slick, but brings with it all the hassles of the past attempts to re-skin admin: it breaks legacy custom pages. AFAIK the admin never promised an "API" (if we can call html that), at the time 1.4 broke most of my custom admin templat

Re: Django Admin new look

2015-03-04 Thread Collin Anderson
Re theming layer: In theory (if you use collectstatic :) it should be possible to include an "app" that overrides the css files. I believe it the custom app would need to be placed above django.contrib.admin in INSTALLED_APPS. Or you can even override the files by putting them in a STATICFILES_

Re: Django Admin new look

2015-03-04 Thread Curtis Maloney
Looks pretty slick, but brings with it all the hassles of the past attempts to re-skin admin: it breaks legacy custom pages. I wish we could standardise a theming layer for admin... allow legacy templates, or switching to new, clean, themable templates... Perhaps this could be integrated with the

Re: Django Admin New Look

2015-03-04 Thread Riccardo Magliocchetti
Il 04/03/2015 21:56, elky ha scritto: Quick summary of the PR discussion : * Everyone (ok, probably not) understands that current admin interface looks old * Green theme I used from djangoproject site isn't good idea - admin shouldn't be assoc

Re: Django Admin New Look

2015-03-04 Thread elky
Quick summary of the PR discussion : - Everyone (ok, probably not) understands that current admin interface looks old - Green theme I used from djangoproject site isn't good idea - admin shouldn't be associated with brand - It's better

Django Admin New Look

2015-03-04 Thread Alexey
Hi guys, I think django admin needs new look. I played with styles recently and that's the result: https://github.com/django/django/pull/4232 Inspired by a new djangoproject.com site. New theme looks modern, fresh and clean. There are CSS changes only. No any HTML changes. Let's discuss it. I w