Re: Django 5.1 - LoginRequiredMiddleware

2024-08-08 Thread אורי
Hi, I read the updated Django 5.1 release notes and I think now it's more clear that LoginRequiredMiddleware is only enabled if we enable it, and is not enabled by default. Thanks, Uri. אורי u...@speedy.net On Wed, Aug 7, 2024 at 9:29 AM Adam Johnson wrote: > I’ve opened a PR for a small docs

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-07 Thread אורי
Thank you. אורי u...@speedy.net On Wed, Aug 7, 2024 at 10:29 AM Adam Johnson wrote: > I’ve opened a PR for a small docs tweak that may help clarify the release > note: https://github.com/django/django/pull/18455 . > > On Wed, 7 Aug 2024, at 01:29, אורי wrote: > > > אורי > u...@speedy.net > > >

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-07 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I’ve opened a PR for a small docs tweak that may help clarify the release note: https://github.com/django/django/pull/18455 . On Wed, 7 Aug 2024, at 01:29, אורי wrote: > > אורי > u...@speedy.net > > > On Wed, Aug 7, 2024 at 3:17 AM James Bennett wrote: >> On Tue, Aug 6, 2024 at 4:37 PM אורי

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-06 Thread אורי
אורי u...@speedy.net On Wed, Aug 7, 2024 at 3:17 AM James Bennett wrote: > On Tue, Aug 6, 2024 at 4:37 PM אורי wrote: > >> No. I didn't see in the documentation of LoginRequiredMiddleware >> any MIDDLEWARE setting. >> >> >> https://docs.djangoproject.com/en/5.1/ref/middleware/#django.contrib.a

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-06 Thread James Bennett
On Tue, Aug 6, 2024 at 4:37 PM אורי wrote: > No. I didn't see in the documentation of LoginRequiredMiddleware > any MIDDLEWARE setting. > > > https://docs.djangoproject.com/en/5.1/ref/middleware/#django.contrib.auth.middleware.LoginRequiredMiddleware > > > https://docs.djangoproject.com/en/5.1/re

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-06 Thread אורי
אורי u...@speedy.net On Tue, Aug 6, 2024 at 8:37 PM 'Adam Johnson' via Django developers (Contributions to Django itself) wrote: > Did you add the middleware to the MIDDLEWARE setting? > No. I didn't see in the documentation of LoginRequiredMiddleware any MIDDLEWARE setting. https://docs.djan

Re: Django 5.1 - LoginRequiredMiddleware

2024-08-06 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Did you add the middleware to the MIDDLEWARE setting? On Tue, 6 Aug 2024, at 17:19, אורי wrote: > Hi, > > I read about LoginRequiredMiddleware in Django 5.1 release notes, where it's > written "The new LoginRequiredMiddleware redirects all unauthenticated > requests to a login page." > > I wan

Django 5.1 - LoginRequiredMiddleware

2024-08-06 Thread אורי
Hi, I read about LoginRequiredMiddleware in Django 5.1 release notes, where it's written "The new LoginRequiredMiddleware redirects all unauthenticated requests to a login page." I wanted to check so I installed django-5.1rc1 and I checked static pages without login locally, and they work without