Re: Deprecating old keyword syntax in DTL

2015-08-08 Thread Tim Graham
We could accept a patch to remove usage of the legacy syntax in Django templates right away (I just merged the same for ifequal/ifnotequal). Does removing this improve performance for the affected tags or is the main benefit simpler code? I don't see a need for an accelerated deprecation. On Sa

Re: Deprecating old keyword syntax in DTL

2015-08-08 Thread Curtis Maloney
For reference, the old PR is here : https://github.com/django/django/pull/1619/files Unfortunately, it doesn't rebase cleanly onto master... some very odd stuff shows up... but it wouldn't take much to regenerate this work. -- Curtis On Saturday, 8 August 2015 21:33:22 UTC+10, Curtis Maloney w

Deprecating old keyword syntax in DTL

2015-08-08 Thread Curtis Maloney
Long ago, the keyword syntax in Django templates was: expr as name but was changed to look more like Python as: name=expr However, the facility to parse the old syntax is still there, but will silently fail unless you pass "support_legacy" to token_kwargs. In fact, it is enabled for "wi