Re: Database template loader

2007-02-25 Thread Jacob Kaplan-Moss
On 2/25/07, Jannis Leidel <[EMAIL PROTECTED]> wrote: > I now moved everything to the django.contrib.dbtemplates app and > added a utility which syncs all filesystem based templates in > TEMPLATES_DIRS to the database. The docs are now in dbtemplates.txt. Awesome :) > Could someone please explain

Re: Database template loader

2007-02-25 Thread Jannis Leidel
Hi all! Am 24.02.2007 um 23:30 schrieb Jacob Kaplan-Moss: > Yeah, I'd just go ahead and move it all into contrib; seems the best > place for this stuff. I now moved everything to the django.contrib.dbtemplates app and added a utility which syncs all filesystem based templates in TEMPLATES_D

Re: Database template loader

2007-02-24 Thread Jacob Kaplan-Moss
On 2/24/07, Jannis Leidel <[EMAIL PROTECTED]> wrote: > * Moved the models.py to a new contrib app > "django.contrib.dbtemplates". "dbtemplates" to prevent confusion with > "templates" directories. > > * Moved the "load_template_source" function to the new file django/ > template/loaders/database.p

Re: Database template loader

2007-02-24 Thread Jannis Leidel
Am 24.02.2007 um 19:32 schrieb Michael Radziej: > Jacob Kaplan-Moss: >> * I don't much like the model living in >> django.template.loaders.database; that seems like the wrong place for >> it. I'd love to see you move the code into django.contrib. > > Only the code for the model, or also the tem

Re: Database template loader

2007-02-24 Thread Michael Radziej
Hi Jacob, Jacob Kaplan-Moss: > * I don't much like the model living in > django.template.loaders.database; that seems like the wrong place for > it. I'd love to see you move the code into django.contrib. Only the code for the model, or also the template loader (i.e., everything)? Michael --

Re: Database template loader

2007-02-24 Thread Jacob Kaplan-Moss
Hey Jannis -- Thanks for the patch, it looks pretty good. I've got a few bits of feedback before it can be checked in, however: * I don't much like the model living in django.template.loaders.database; that seems like the wrong place for it. I'd love to see you move the code into django.contrib

Re: Database template loader

2007-02-24 Thread Jannis Leidel
to provide the same template across multiple > > sites and works with Flatpages. > > > It's tested with the latest trunk. Please go to the google code site > > [2] for an overview, a little howto and the source code. I hope you > > like it.. > > The idea of a

Re: Database template loader

2007-02-24 Thread Michael Radziej
rks with Flatpages. > > It's tested with the latest trunk. Please go to the google code site > [2] for an overview, a little howto and the source code. I hope you > like it.. The idea of a database template loader has already been accepted. Please add your code in the form of a pa

Database template loader

2007-02-23 Thread Jannis Leidel
Hi list, Concerning Ticket #632 [1] I created a template loader for Django which fetches the templates from a database. It integrates well with the Site app if you want to provide the same template across multiple sites and works with Flatpages. It's tested with the latest trunk. Please go to th