Re: DDN on #9284

2009-03-29 Thread Joseph Kocherhans
On Mon, Mar 23, 2009 at 7:17 PM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > The approach looks better. I'd be tempted to lift a couple of those > leading-underscore methods up to just being normal methods. Found myself > having to override a few of those things lately when wanting t

Re: DDN on #9284

2009-03-24 Thread Alex Gaynor
On Mon, Mar 23, 2009 at 8:17 PM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > Hey Joseph, > > On Mon, 2009-03-23 at 15:32 -0500, Joseph Kocherhans wrote: > > #9284 [1] Has a patch to make BaseModelFormSet call ModelForm.save() > > when saving objects rather than using completely custo

Re: DDN on #9284

2009-03-23 Thread Malcolm Tredinnick
Hey Joseph, On Mon, 2009-03-23 at 15:32 -0500, Joseph Kocherhans wrote: > #9284 [1] Has a patch to make BaseModelFormSet call ModelForm.save() > when saving objects rather than using completely custom code as it > does now. I think this is the "right thing (tm)" to do, but it will > break people'

DDN on #9284

2009-03-23 Thread Joseph Kocherhans
#9284 [1] Has a patch to make BaseModelFormSet call ModelForm.save() when saving objects rather than using completely custom code as it does now. I think this is the "right thing (tm)" to do, but it will break people's code who have overridden the formset's __init__ method and mucked around with th