Re: Clearing cache between tests (#11505)

2011-10-31 Thread Jim Dalton
On Oct 30, 2011, at 4:19 PM, Jeremy Dunck wrote: Hi Jeremy, > I locally have a test-runner class that calls .clear() on setUp. > Works for me. But we run CI, so test against prod. I needed to point > to different CACHES under test to avoid flushing prod cache 20 times > per day. Right. You've

Re: Clearing cache between tests (#11505)

2011-10-30 Thread Jeremy Dunck
On Sun, Oct 30, 2011 at 4:19 PM, Jeremy Dunck wrote: > On Sun, Oct 30, 2011 at 8:48 AM, Jim Dalton wrote: > ... >> Anyhow, I honestly agree with you and Aymeric that a simple cache.clear() is >> fine, but I thought the CLEAR_BETWEEN_TESTS flag was a good way to answer >> any objections that we

Re: Clearing cache between tests (#11505)

2011-10-30 Thread Jeremy Dunck
On Sun, Oct 30, 2011 at 8:48 AM, Jim Dalton wrote: ... > Anyhow, I honestly agree with you and Aymeric that a simple cache.clear() is > fine, but I thought the CLEAR_BETWEEN_TESTS flag was a good way to answer any > objections that we should be cautious about clearing the cache. If there are >

Re: Clearing cache between tests (#11505)

2011-10-30 Thread Jim Dalton
Hi Lukasz, On Oct 30, 2011, at 3:26 AM, Łukasz Rekucki wrote: >> If I personally were given the choice between cache.clear() and nothing at >> all, i'd take cache.clear() and be careful with it. But I'm not sure if the >> rest of the community is willing to accept such a solution. Hence the >>

Re: Clearing cache between tests (#11505)

2011-10-30 Thread Łukasz Rekucki
> If I personally were given the choice between cache.clear() and nothing at > all, i'd take cache.clear() and be careful with it. But I'm not sure if the > rest of the community is willing to accept such a solution. Hence the > CLEAR_BETWEEN_TESTS flag as a compromise. But the flag doesn't sol

Re: Clearing cache between tests (#11505)

2011-10-29 Thread Jim Dalton
On Oct 29, 2011, at 11:14 AM, Aymeric Augustin wrote: Thank Aymeric, > >> As an alternative, I propose we: >> >> 1. Add a new optional setting under CACHES, CLEAR_BETWEEN_TESTS. The default >> for this setting is False. To be clear, the value is set independently for >> each cache defined in

Re: Clearing cache between tests (#11505)

2011-10-29 Thread Aymeric Augustin
Hi Jim, On 29 oct. 2011, at 19:07, Jim Dalton wrote: > I noticed that Aymeric Augustin committed a patch last week [17042] that > fixed some issues in the cache backends. Apparently the fact that the cache > carries over test to test remains a problem. Yes, while working on the cache tests, I

Clearing cache between tests (#11505)

2011-10-29 Thread Jim Dalton
I noticed that Aymeric Augustin committed a patch last week [17042] that fixed some issues in the cache backends. Apparently the fact that the cache carries over test to test remains a problem. I've progressed pretty far with an aggressive "fix" for this problem with the patch in #11505. The cu