Re: Clear all filters

2020-05-19 Thread Adam Johnson
Fran, your design looks nice. I think we should make a ticket that combines making the "X total" link preserve the query params and adding your other suggested changes. On Tue, 19 May 2020 at 08:12, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > On 18 May 2020, at 11:10, Mariusz

Re: Clear all filters

2020-05-19 Thread Aymeric Augustin
On 18 May 2020, at 11:10, Mariusz Felisiak wrote: > Link to the right of the search box ("X total") already removes the entire > query string, so ... Ah, this is a bug I'm hitting! I have a small personal app where I classify data. Some classification is automated with regexes. New data need

Re: Clear all filters

2020-05-18 Thread Mariusz Felisiak
OK, I added new ticket https://code.djangoproject.com/ticket/31603. Thanks y'all -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an em

Re: Clear all filters

2020-05-18 Thread Markus Holtermann
I tend to agree with Adam. >From a UI/UX perspective, the location where the "Clear all filters" button >is, as well as the wording, suggest to me that it's only the filters on the >right side. The search query, while technically filtering the query set, >doesn

Re: Clear all filters

2020-05-18 Thread Mariusz Felisiak
> > I disagree Mariusz. I would NOT expect this. The "Clear all filters" > button is grouped with the filters, visually separate from the search and > sort controls. It's a very legitimate use case to clear the filters and > maintain the search or sort, and quite

Re: Clear all filters

2020-05-18 Thread Adam Johnson
I disagree Mariusz. I would NOT expect this. The "Clear all filters" button is grouped with the filters, visually separate from the search and sort controls. It's a very legitimate use case to clear the filters and maintain the search or sort, and quite a common workflow when t

Re: Clear all filters

2020-05-17 Thread Mariusz Felisiak
Hi, IMO the current behavior is expected, it is also included in the ticket description (see comment[1]). Best, Mariusz [1] https://code.djangoproject.com/ticket/27888#comment:1 -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions t