Re: Changing label style in some widgets RE: 4860

2007-12-11 Thread [EMAIL PROTECTED]
From http://www.w3.org/TR/html4/interact/forms.html#edef-LABEL "for: This attribute explicitly associates the label being defined with another control. When present, the value of this attribute must be the same as the value of the id attribute of some other control in the same document. When absen

Re: Changing label style in some widgets RE: 4860

2007-12-07 Thread Sandro
Actually, all of the patches I submitted need to be deleted. My patches exhibit a certain html style (which this thread aims to discuss) but my patches don't add the 'id' attribute which makes them incorrect. Ivan's patch seems to solve the IE rendering problem and maintains consistency with the R

Re: Changing label style in some widgets RE: 4860

2007-12-07 Thread Ivan Sagalaev
Malcolm Tredinnick wrote: > Okay, I think my brain just melted trying to follow the various > sub-problems mentioned here. Can somebody make sure that whatever issues > are brought up here are turned into tickets, I'll try to clarify since it looks that I'm responsible for most of the confusion.

Re: Changing label style in some widgets RE: 4860

2007-12-07 Thread Malcolm Tredinnick
On Wed, 2007-12-05 at 19:23 +0300, Ivan Sagalaev wrote: > Patryk Zawadzki wrote: > > Which is correct and desired. If not Internet Explorer, even for="..." > > and id="..." wouldn't be needed (and it's not there with current > > Django). > > BTW, in current Django presence of for and id should b

Re: Changing label style in some widgets RE: 4860

2007-12-05 Thread Ivan Sagalaev
Patryk Zawadzki wrote: > Which is correct and desired. If not Internet Explorer, even for="..." > and id="..." wouldn't be needed (and it's not there with current > Django). BTW, in current Django presence of for and id should be controlled by an auto_id parameter of a form. However RadioSelect

Re: Changing label style in some widgets RE: 4860

2007-12-05 Thread Patryk Zawadzki
2007/12/5, Sandro <[EMAIL PROTECTED]>: > I'd like to start a discussion that branches off of ticket 4860. There > are a few django widgets (RadioSelect, CheckboxSelectMultiple, > others?) which produce html that has an input nested inside a label. > As Ivan pointed out, this is valid html but it j

Re: Changing label style in some widgets RE: 4860

2007-12-05 Thread Ivan Sagalaev
Sandro wrote: > Right now, django produces: > value="P" name="language" /> Python Not related to the discussion but for the accuracy's sake I'd like to note that right now Django produces without for=".." at all which this bug is about. --~--~-~--~~~---~--~~ Y

Changing label style in some widgets RE: 4860

2007-12-05 Thread Sandro
I'd like to start a discussion that branches off of ticket 4860. There are a few django widgets (RadioSelect, CheckboxSelectMultiple, others?) which produce html that has an input nested inside a label. As Ivan pointed out, this is valid html but it just doesn't sit right with me as I always code