Re: Changeset 16297

2011-05-31 Thread Alex Gaynor
On Tue, May 31, 2011 at 8:26 AM, Luke Plant wrote: > On 31/05/11 14:55, Alex Gaynor wrote: > > > I came up with an alternate approach that is much > > simpler: http://paste.pocoo.org/show/398303/ , all tests pass with this. > > Any objections to checking this in? > > This is much better than my

Re: Changeset 16297

2011-05-31 Thread Luke Plant
On 31/05/11 14:55, Alex Gaynor wrote: > I came up with an alternate approach that is much > simpler: http://paste.pocoo.org/show/398303/ , all tests pass with this. > Any objections to checking this in? This is much better than my attempt, but I spotted some problems. This line seems to have a b

Re: Changeset 16297

2011-05-31 Thread Alex Gaynor
On Tue, May 31, 2011 at 3:39 AM, Luke Plant wrote: > On 31/05/11 00:26, Alex Gaynor wrote: > > Hi all, > > > > I'm looking at r16297 (https://code.djangoproject.com/changeset/16297), > > and I don't like this approach, I understand what it is trying

Re: Changeset 16297

2011-05-31 Thread Luke Plant
On 31/05/11 00:26, Alex Gaynor wrote: > Hi all, > > I'm looking at r16297 (https://code.djangoproject.com/changeset/16297), > and I don't like this approach, I understand what it is trying to > accomplish, but it has several downsides that don't appear to have

Changeset 16297

2011-05-30 Thread Alex Gaynor
Hi all, I'm looking at r16297 (https://code.djangoproject.com/changeset/16297), and I don't like this approach, I understand what it is trying to accomplish, but it has several downsides that don't appear to have been considered: a) On CPython a class object is pretty large, an