Re: Change list default sort modification proposal

2009-09-23 Thread Joshua Russo
Take a look in test\regressiontests\admin_views\tests.py AdminViewBasicTest.testChangeListSortingXXX() methods. They should give you a good place to start. On Wed, Sep 23, 2009 at 6:18 PM, Ben Davis wrote: > I would write the tests though I'm not 100% sure how to write regression > tests for a U

Re: Change list default sort modification proposal

2009-09-23 Thread Ben Davis
I would write the tests though I'm not 100% sure how to write regression tests for a UI change... any suggestions on how to go about doing that? On Thu, Sep 17, 2009 at 2:04 PM, Joshua Russo wrote: > I don't have any say in what gets accepted or not but I do believe that > your solution is a de

Re: Change list default sort modification proposal

2009-09-17 Thread Joshua Russo
I don't have any say in what gets accepted or not but I do believe that your solution is a decent one. I'm continuing with mine because it addresses a current need simply and can be (fairly) easily tested. If you can create the regression tests for yours then I believe you might get more traction.

Re: Change list default sort modification proposal

2009-09-17 Thread Ben Davis
I'm not sure if anyone's seen this, but I've written a patch for multi-sort columns in the changelist ui here: http://code.djangoproject.com/ticket/11868 Not sure if this is what you guys had in mind, but I'd be interested in your feedback. On Thu, Sep 17, 2009 at 12:57 PM, Joshua Russo wrote:

Re: Change list default sort modification proposal

2009-09-17 Thread Joshua Russo
Sorry for dragging this back out of the depths but I was reviewing my code for regression testing and I noticed I had missed this comment way back when. Where is this named sort option documented? It seems to me that the implementation that I have here would still be useful even if you could ass

Re: Change list default sort modification proposal

2009-08-13 Thread Rock
My suggestion for handling the UI for multi-column sorts is to allow the definition of named sorts in a manner similar to the way that the default sorting is defined. With this in place, additional multi column orders can be accomplished simply by using this name as a sort selection and applying t

Re: Change list default sort modification proposal

2009-08-11 Thread Malcolm Tredinnick
For those, like me, wondering what this proposal was about, it's concerning changing sorting in the admin interface to initially use the full set of fields specified in Meta.ordering on the model. What I can't work out yet, due to difficulty in reviewing the patch, mentioned below, is whether it

Re: Change list default sort modification proposal

2009-08-11 Thread Joshua Russo
On Tue, Aug 11, 2009 at 7:46 PM, Rock wrote: > > Yes. I have a project that could use this immediately. Looking forward > to seeing the ticket and a patch I can try out. Ok, let me know what you think. http://code.djangoproject.com/ticket/11695 --~--~-~--~~~---~--~-

Re: Change list default sort modification proposal

2009-08-11 Thread Rock
Yes. I have a project that could use this immediately. Looking forward to seeing the ticket and a patch I can try out. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group,

Change list default sort modification proposal

2009-08-11 Thread Joshua Russo
I just wanted to toss this out there before creating the ticket. I've tweaked the change list sort handling so that by default it uses the full list of sort columns defined in the model. It sets all of the headers as unselected and then behaves as it currently does if someone selects a header colu