Re: Calling save_m2m() in UserCreationForm.save()

2022-11-27 Thread Mark Gensler
Hi Adam, thanks for the reply. I'll open a ticket and start work on a PR. Mark On Sunday, November 27, 2022 at 10:47:01 AM UTC Adam Johnson wrote: > Your proposal seems reasonable - if actually saving, we should save the > m2m fields too. > > I think the best next step would be to file a ticket

Re: Calling save_m2m() in UserCreationForm.save()

2022-11-27 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Your proposal seems reasonable - if actually saving, we should save the m2m fields too. I think the best next step would be to file a ticket and work on a PR. The first step would be to add a test case reproducing the issue. On Wed, Nov 23, 2022 at 4:59 PM Mark Gensler wrote: > Hello all! > > I

Calling save_m2m() in UserCreationForm.save()

2022-11-23 Thread Mark Gensler
Hello all! I noticed that when calling contrib.auth.forms.UserCreationForm.save(), self.save_m2m() is not called when commit=True. This caused an issue in one of my projects which uses a custom User model with ManyToMany fields. Is this something that should be changed? I saw in the docs [1] t