Re: Call for feedback: First GSoC patch ready to land

2009-11-17 Thread Russell Keith-Magee
On Wed, Nov 18, 2009 at 12:03 AM, Schmilblick wrote: > Sorry for crashing the list, but how does this affect this bug: > http://code.djangoproject.com/ticket/5390 ? > > I'm currently using django with the patch provided in that ticket, and > the latest commits regarding the gsoc-project created a

Re: Call for feedback: First GSoC patch ready to land

2009-11-17 Thread Schmilblick
Sorry for crashing the list, but how does this affect this bug: http://code.djangoproject.com/ticket/5390 ? I'm currently using django with the patch provided in that ticket, and the latest commits regarding the gsoc-project created a diff im not sure how to handle. Let me know if you need any mo

Re: Call for feedback: First GSoC patch ready to land

2009-11-02 Thread Russell Keith-Magee
On Mon, Nov 2, 2009 at 11:40 PM, Jacob Kaplan-Moss wrote: > > Hi Russ -- > > I'm +1 on merging the patch immediately. I have some feedback on the > couple of issues you raised below, but I see no reason they can't be > addressed after merging. > > On Fri, Oct 30, 2009 at 3:33 AM, Russell Keith-Ma

Re: Call for feedback: First GSoC patch ready to land

2009-11-02 Thread Jacob Kaplan-Moss
Hi Russ -- I'm +1 on merging the patch immediately. I have some feedback on the couple of issues you raised below, but I see no reason they can't be addressed after merging. On Fri, Oct 30, 2009 at 3:33 AM, Russell Keith-Magee wrote: > The automatically generated m2m model is the equivalent of

Re: Call for feedback: First GSoC patch ready to land

2009-10-30 Thread Russell Keith-Magee
On Sat, Oct 31, 2009 at 9:53 AM, Russell Keith-Magee wrote: > On Sat, Oct 31, 2009 at 9:36 AM, Johannes Dollinger > wrote: >> >> The m2m-refactor patch breaks ManyToManyFields on abstract models: >> "AssertionError: ForeignKey cannot define a relation with abstract >> class A" > > Thanks for the

Re: Call for feedback: First GSoC patch ready to land

2009-10-30 Thread Russell Keith-Magee
On Sat, Oct 31, 2009 at 9:36 AM, Johannes Dollinger wrote: > > The m2m-refactor patch breaks ManyToManyFields on abstract models: > "AssertionError: ForeignKey cannot define a relation with abstract > class A" Thanks for the report, Johannes. I'll take a look at this and see what I can do about

Re: Call for feedback: First GSoC patch ready to land

2009-10-30 Thread Johannes Dollinger
The m2m-refactor patch breaks ManyToManyFields on abstract models: "AssertionError: ForeignKey cannot define a relation with abstract class A" {{{ class R(models.Model): pass class A(models.Model): r_set = models.ManyToManyField(R, related_name="%(class)s_set") class Meta:

Re: Call for feedback: First GSoC patch ready to land

2009-10-30 Thread Russell Keith-Magee
On Oct 30, 4:33 pm, Russell Keith-Magee wrote: > Hi all, > > I've just finished the polishing the first part of Alex's GSoC work to > add Multi-db, which I'd like to commit. This is a call for feedback. I forgot to mention - the patch _should_ be completely backwards compatible, and require no

Call for feedback: First GSoC patch ready to land

2009-10-30 Thread Russell Keith-Magee
Hi all, I've just finished the polishing the first part of Alex's GSoC work to add Multi-db, which I'd like to commit. This is a call for feedback. This first patch isn't directly related to multi-db, but it is a prerequisite that will allow the multi-db code to function. The goal of this patch