Re: CSRF middleware calculates new tokens that are never used

2015-04-24 Thread jaycox
On Friday, April 24, 2015 at 12:18:08 PM UTC-7, Carl Meyer wrote: > > > Wow. I'm surprised that generating a CSRF token is that expensive, but > it doesn't really matter; if it doesn't need to be done for a given > request, there's no reason to do it. > > Most of that time is spent in posix.ur

Re: CSRF middleware calculates new tokens that are never used

2015-04-24 Thread Carl Meyer
Hi Jay, On 04/24/2015 12:29 PM, jay...@linear3d.com wrote: > It was requested of me that I post this here to get some more eyes on it: > > Django ticket: https://code.djangoproject.com/ticket/24696 > Pull request: https://github.com/django/django/pull/4550 > > I noticed that the csrf middleware

CSRF middleware calculates new tokens that are never used

2015-04-24 Thread jaycox
It was requested of me that I post this here to get some more eyes on it: Django ticket: https://code.djangoproject.com/ticket/24696 Pull request: https://github.com/django/django/pull/4550 I noticed that the csrf middleware will always calculate a new csrf token for any request that does not in