Re: CSRF changes - backwards incompatible

2009-10-31 Thread Luke Plant
On Saturday 31 October 2009 03:04:28 Kegan Gan wrote: > How does the csrf_token affect TestCase.client.post() ? The token doesn't affect it directly. The HttpRequest class that TestCase uses is hacked so that the middleware and csrf_protect decorator don't actually reject requests which have t

Re: CSRF changes - backwards incompatible

2009-10-30 Thread Kegan Gan
How does the csrf_token affect TestCase.client.post() ? On Oct 31, 9:28 am, rebus_ wrote: > I would go with the idea that your settings are probably wrong. Just > tried trunk and it seems to work fine. > > You should > read:http://docs.djangoproject.com/en/dev/ref/contrib/csrf/#upgrading-notes

Re: CSRF changes - backwards incompatible

2009-10-30 Thread rebus_
I would go with the idea that your settings are probably wrong. Just tried trunk and it seems to work fine. You should read: http://docs.djangoproject.com/en/dev/ref/contrib/csrf/#upgrading-notes Also, this is list is not for general Django troubleshooting but rather for Django development. Dav

Re: CSRF changes - backwards incompatible

2009-10-30 Thread vl4dt
I just updated my django installation to the latest trunk. I'm new do Django but I'm having this problem, I just ran the usual: django-admin.py startproject testprj cd testprj (edited settings.py so it uses a sqlite3 database) python manage.py syncdb python manage.py runserver Once the server is

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Sean Brant
Interesting note. A co-worker of my has been working with the poll tutorial for a couple days now and just got to part 3 which now contains the {% csrf_token %} tag. He could not figure out how why he was getting an error that the csrf_token tag could not be loaded. I'm not sure how wide spread t

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Jacob Kaplan-Moss
On Tue, Oct 27, 2009 at 1:54 PM, Luke Plant wrote: > There is a patch on http://code.djangoproject.com/ticket/12095 that > tries to address this. Repeating what I said on #django-dev this morning, I'm +1 on this patch. Rending forms via an inclusion tag is a pretty common pattern [1], and we sho

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
On Tuesday 27 October 2009 13:03:14 Luke Plant wrote: > If you have supplied custom templates to contrib views that accept > POST requests (e.g. auth login etc.), the template may need > updating. The steps needed are fully described in the docs, but in > short: > > Inside all elements, add

Re: CSRF changes - backwards incompatible

2009-10-27 Thread TheMaTrIx
I fixed the django-pages-cms app by adding the csrf token tags into the POST forms in the apps admin pages. On 27 okt, 15:36, Luke Plant wrote: > On Tuesday 27 October 2009 13:30:42 TheMaTrIx wrote: > > > I don't understand something here. csrf is stated to be a option > >  that needs to be enab

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
On Tuesday 27 October 2009 13:30:42 TheMaTrIx wrote: > I don't understand something here. csrf is stated to be a option > that needs to be enabled if you wish to use it for views, yet I > just ran a trunk sync and boom, django-pages-cms is busted, > without me enabling anything. The CSRF prote

Re: CSRF changes - backwards incompatible

2009-10-27 Thread TheMaTrIx
I don't understand something here. csrf is stated to be a option that needs to be enabled if you wish to use it for views, yet I just ran a trunk sync and boom, django-pages-cms is busted, without me enabling anything. Is it an always on feature or is something funky? On 27 okt, 14:17, Luke Plan

Re: CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
On Tuesday 27 October 2009 13:07:14 rebus_ wrote: > And there are also some typos in guide: Cheers! Fixed now. After this patch, I won't be sad if I never have to type 'csrf' (or 'crsf') ever again :-) But unfortunately I will... Luke -- Environmentalists are much too concerned with plane

Re: CSRF changes - backwards incompatible

2009-10-27 Thread rebus_
2009/10/27 Luke Plant : > If you have supplied custom templates to contrib views that accept > POST requests (e.g. auth login etc.), the template may need updating. > The steps needed are fully described in the docs, but in short: > >  Inside all elements, add {% csrf_token %} > > That's it. Apo

CSRF changes - backwards incompatible

2009-10-27 Thread Luke Plant
Hi all, For those following trunk, the CSRF changes have now landed (apart from Simon's proposed refinements). At first I thought this would be perfectly seamless, not requiring any immediate action, and it therefore didn't warrant a note to django- devs. However, there are circumstances when