Re: CSRF / SafeForm

2009-01-06 Thread Bob Thomas
I added a ticket (with patch) for implementing the template tag: http://code.djangoproject.com/ticket/9977 It also adds a CSRF context processor, which is used by the tag. The diff doesn't look quite right. There obviously needs to be an empty __init__.py file added to the templatetags folder for

Re: CSRF / SafeForm

2009-01-05 Thread Luke Plant
I wrote: > If you want to implement any of this, I'm not planning on working > on it for this next week, I'll get in touch when I start in case > you've made some progress. I'm now not going to be able to implement this for the 1.1 deadline. I could review and commit if someone else implemente

Re: CSRF / SafeForm

2008-12-23 Thread Luke Plant
On Tuesday 23 December 2008 16:51:46 Bob Thomas wrote: > On Dec 3, 9:14 am, Luke Plant wrote: > > At the moment, once you've factored everything in, I think 'view > > middleware' + template tag is the way to go, with some more > > custom solution for loginCSRF.  The SafeForm ends up having an >

Re: CSRF / SafeForm

2008-12-23 Thread Bob Thomas
On Dec 3, 9:14 am, Luke Plant wrote: > > At the moment, once you've factored everything in, I think 'view > middleware' + template tag is the way to go, with some more custom > solution for loginCSRF.  The SafeForm ends up having an unwieldly > API, which means it won't be used or could be used

Re: CSRF / SafeForm

2008-12-15 Thread Jacob Kaplan-Moss
On Wed, Dec 3, 2008 at 8:14 AM, Luke Plant wrote: > == Conclusion == > > At the moment, once you've factored everything in, I think 'view > middleware' + template tag is the way to go, with some more custom > solution for login CSRF. The SafeForm ends up having an unwieldly > API, which means it

CSRF / SafeForm

2008-12-03 Thread Luke Plant
Hi all, I'm thinking about 'championing' this thing, having just done a bit more work on the existing CsrfMiddleware [1], and I've done some more thinking about the different issues. LONG email, sorry, this is quite complex stuff. == First == Simon suggested that the current middleware displa