Re: CIDR Support for Django

2006-04-17 Thread Rob Shakir
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Rob Shakir wrote: > This is something I'm prepared to do - however, due to task sizes, and > the fact it's not going to fit in during the course of development of > the project I'm working on - it's going to take a little while. I > definitely think t

Re: CIDR Support for Django

2006-04-17 Thread Rob Shakir
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Russell Keith-Magee wrote: > Ok; I'm open to be convinced. Here's how to convince me: > This is something I'm prepared to do - however, due to task sizes, and the fact it's not going to fit in during the course of development of the project I'm work

Re: CIDR Support for Django

2006-04-16 Thread Russell Keith-Magee
On 4/14/06, Rob Shakir <[EMAIL PROTECTED]> wrote: > > Thanks for the comments - I'll update the patch to add documentation > entries. Don't feel like you can't buck the trend and add unit tests, too :-) > Whilst I can see the point ref: adding support for datatypes that aren't > supported formal

Re: CIDR Support for Django

2006-04-14 Thread Rob Shakir
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Russell Keith-Magee wrote: > I haven't looked too hard yet, but as a patch, it looks good. A > _fantastic_ patch would also have unit test, but there aren't any unit > tests for the existing DB datatypes, so I'll let you off the hook :-) > A Documenta

Re: CIDR Support for Django

2006-04-13 Thread Russell Keith-Magee
On 4/14/06, Rob Shakir <[EMAIL PROTECTED]> wrote: > I've just started using django today for a internal project, which > centres around network management. I notice that there was no support > for the cidr PostgreSQL datatype, and so I've added it. Please find the > diff attached. Thanks for the

CIDR Support for Django

2006-04-13 Thread Rob Shakir
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I've just started using django today for a internal project, which centres around network management. I notice that there was no support for the cidr PostgreSQL datatype, and so I've added it. Please find the diff attached. I'm not sure if there'