Re: Bulk delete - lets try this again...

2006-01-29 Thread Russell Keith-Magee
On 1/26/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 1/26/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Yeah -- I'm not 100% comfortable with coupling object instances to a > > manager. It seems a bit wonky... > > I'll grant that the mechanism of using the 'default' manager for the

Re: Bulk delete - lets try this again...

2006-01-25 Thread Russell Keith-Magee
On 1/26/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > On 1/25/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > Comments on this thread seem to have gone dead - are there any > > objections out there to me committing this patch (the newer patch with > > object delete deferring to the man

Re: Bulk delete - lets try this again...

2006-01-25 Thread Adrian Holovaty
On 1/25/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Comments on this thread seem to have gone dead - are there any > objections out there to me committing this patch (the newer patch with > object delete deferring to the manager)? Yeah -- I'm not 100% comfortable with coupling object ins

Re: Bulk delete - lets try this again...

2006-01-25 Thread Russell Keith-Magee
On 1/21/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > I've attached (but not committed) a patch for bulk delete in > magic-removal (Ticket #1219). Comments on this thread seem to have gone dead - are there any objections out there to me committing this patch (the newer patch with object d

Re: Bulk delete - lets try this again...

2006-01-22 Thread hugo
>default manager works fine for the simple case, but how do propose to >choose the 'correct' manager if there are multiple managers involved? The objects do have some meta data - just plug a "source" meta data in there that points back to the manager from where the object was loaded? Or maybe jus

Re: Bulk delete - lets try this again...

2006-01-21 Thread Russell Keith-Magee
On 1/21/06, hugo <[EMAIL PROTECTED]> wrote: > So I am +1 on that change, I've attached an alternate version of the patch that implements this idea. In this version, the object instance defers to the default manager for delete functionality. This removes the duplication of SQL delete logic, but

Re: Bulk delete - lets try this again...

2006-01-21 Thread hugo
>However, it would >mean moving some model logic into the manager, making Model.delete() >defer to the manager to collate and remove objects. Would this rub >anyone the wrong (or right) way? Actually I think sooner or later we will need objects to keep track of the manager they came from - for ex

Bulk delete - lets try this again...

2006-01-21 Thread Russell Keith-Magee
Hi guys Ok, lets try this one again. I've attached (but not committed) a patch for bulk delete in magic-removal (Ticket #1219). Issues worth note: - pre-delete/post-delete signals are sent for all deleted objects. This could turn into a bit of a signal flood if you delete a lot of objects, or