Re: Benchmarking change to query.get() #15361

2011-02-25 Thread mmcnickle
On Feb 24, 11:40 pm, Russell Keith-Magee wrote: > Optimizing Django's retrieval code for the bad design > case strikes me as equally bad design. I say document this and leave > the code as is. Ok, I'll write a documentation patch for this for the optimisation section. Good job for catching this

Re: Benchmarking change to query.get() #15361

2011-02-24 Thread Russell Keith-Magee
On Thu, Feb 24, 2011 at 11:15 PM, Jacob Kaplan-Moss wrote: > On Thu, Feb 24, 2011 at 4:59 PM, mmcnickle wrote: >> So there you have it, we have a small regression in performance for >> the most common case use, and a huge potential gain for the less used >> (and some would argue, badly designed)

Re: Benchmarking change to query.get() #15361

2011-02-24 Thread Jacob Kaplan-Moss
On Thu, Feb 24, 2011 at 4:59 PM, mmcnickle wrote: > So there you have it, we have a small regression in performance for > the most common case use, and a huge potential gain for the less used > (and some would argue, badly designed) query. > > What do you think, is the gain worth the hit? Is it po

Benchmarking change to query.get() #15361

2011-02-24 Thread mmcnickle
Hi All, Background to this post is available at http://code.djangoproject.com/ticket/15361 I've created a better benchmark in order to test where the change in the above ticket causes a performance regression. These are the results of those tests. First of all, the results are based on query.ge