Re: BaseModelFormSet and ModelForm.instance

2008-08-28 Thread Justin Fagnani
So I saw that #8160 has been pushed to post 1.0, which is understandable, but I've still been working on it since I need it fixed for a project. My previous patch was indeed failing all the model_formsets test, and it now passes all but one. The one test it fails on seems a bit odd to me though.

Re: BaseModelFormSet and ModelForm.instance

2008-08-20 Thread Brian Rosner
On Wed, Aug 20, 2008 at 11:42 AM, Justin Fagnani <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 20, 2008 at 8:39 AM, Brian Rosner <[EMAIL PROTECTED]> wrote: >> I am slightly unclear on what is allowed to >> be broken in this phase of Django development. I suspect it is okay >> since those methods are

Re: BaseModelFormSet and ModelForm.instance

2008-08-20 Thread Justin Fagnani
On Wed, Aug 20, 2008 at 8:39 AM, Brian Rosner <[EMAIL PROTECTED]> wrote: > I am slightly unclear on what is allowed to > be broken in this phase of Django development. I suspect it is okay > since those methods are not explicitly documented and a quick note on > the wiki would be decent. Someone p

Re: BaseModelFormSet and ModelForm.instance

2008-08-20 Thread Brian Rosner
On Wed, Aug 20, 2008 at 12:57 AM, Justin Fagnani <[EMAIL PROTECTED]> wrote: > ps. The *_factory methods seem odd to me. I wonder why metaclasses > weren't used here, but I understand that it's to close to 1.0 change > anything. Ah, missed this in the first e-mail. There was an effort to do this,

Re: BaseModelFormSet and ModelForm.instance

2008-08-20 Thread Brian Rosner
On Wed, Aug 20, 2008 at 12:57 AM, Justin Fagnani <[EMAIL PROTECTED]> wrote: > I'm not sure what parts of BaseModelFormSet are considered official > API. In the patch ModelForm.save() is now called by > ModelFormSet.save(), and I think the methods save_new, save_existing, > save_existing_objects, a

Re: BaseModelFormSet and ModelForm.instance

2008-08-19 Thread Justin Fagnani
I attached a patch to #8160 that fixes this issue (and probably #8071). I'm not sure what parts of BaseModelFormSet are considered official API. In the patch ModelForm.save() is now called by ModelFormSet.save(), and I think the methods save_new, save_existing, save_existing_objects, and save_new