Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
OK, I've submitted both #5953 and #5952. Thanks! Cedric --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscrib

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
> Excuse me for asking, but did you do something like > album.title = mark_safe(...) I would have asked too ;-) But no -- nothing like that. I'll prepare a small example a fill the ticket later tonight. Cedric --~--~-~--~~~---~--~~ You received this message beca

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
> Probably best to file a ticket with a short example. Otherwise it will > just be forgotten. Right, will do as soon as possible. > The escape filter documentation does say this. Quoting from the docs: > > Applying ``escape`` to a variable that would normally have > auto-escapi

Re: Auto-escaping comitted

2007-11-15 Thread Michael Radziej
On Thu, Nov 15, Cedric Rossi wrote: > Yes, but: > {% blocktrans with album.title|escape as title %} will not escape at > all, whereas > {% blocktrans with album.title|force_escape as title %} will escape > properly. From the quote, it seems that |escape will always result in > one and only one ro

Re: Auto-escaping comitted

2007-11-15 Thread Malcolm Tredinnick
On Thu, 2007-11-15 at 02:20 -0800, Cedric Rossi wrote: > On Nov 14, 2:11 pm, Malcolm Tredinnick <[EMAIL PROTECTED]> > wrote: > > As I've just mentioned on django-users, I finally arrived at a point > > where I'm happy with the forwards-porting of the auto-escaping changes > > and they've been com

Re: Auto-escaping comitted

2007-11-15 Thread Cedric Rossi
On Nov 14, 2:11 pm, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > As I've just mentioned on django-users, I finally arrived at a point > where I'm happy with the forwards-porting of the auto-escaping changes > and they've been committed in r6671. > > There may be a few corner cases in some of th

Re: Auto-escaping comitted

2007-11-14 Thread Malcolm Tredinnick
On Wed, 2007-11-14 at 18:21 +0100, Michael Radziej wrote: [...] > Now, either the super block has been created with autoescaping on and thus > should > be safe, or autoescaping has been intentionally switched off for it. In > either case, I don't see much use for escaping it again. Yes, this lo

Re: Auto-escaping comitted

2007-11-14 Thread Michael Radziej
On Wed, Nov 14, Jason Davies wrote: > > On Nov 14, 1:59 pm, Rudolph <[EMAIL PROTECTED]> wrote: > > > May be I found one corner case. But I'm not sure if this is a bug or a > > feature. When using {{ block.super }} is will be escaped, which is > > IMHO not the common desired result. One can solv

Re: Auto-escaping comitted

2007-11-14 Thread Jason Davies
On Nov 14, 1:59 pm, Rudolph <[EMAIL PROTECTED]> wrote: > May be I found one corner case. But I'm not sure if this is a bug or a > feature. When using {{ block.super }} is will be escaped, which is > IMHO not the common desired result. One can solve this by using > {{ block.super|safe }}, but perh

Re: Auto-escaping comitted

2007-11-14 Thread Rudolph
Thank you very much! May be I found one corner case. But I'm not sure if this is a bug or a feature. When using {{ block.super }} is will be escaped, which is IMHO not the common desired result. One can solve this by using {{ block.super|safe }}, but perhaps it's even more template-developer frie

Auto-escaping comitted

2007-11-14 Thread Malcolm Tredinnick
As I've just mentioned on django-users, I finally arrived at a point where I'm happy with the forwards-porting of the auto-escaping changes and they've been committed in r6671. There may be a few corner cases in some of the contrib apps that I've missed through not using them very much, but I thi