Re: ArrayField: Bug on exact_nested_null

2022-10-13 Thread Ion Alberdi
Hello to all! FYI a PR is available at https://github.com/django/django/pull/16175 So far the PR unwraps ARRAY and lets psycopg2 handle these use cases. Le mardi 11 octobre 2022 à 16:55:25 UTC+2, Ion Alberdi a écrit : > Hi Jörg! > > >At this point I think ArrayField should always use ARRAY const

Re: ArrayField: Bug on exact_nested_null

2022-10-11 Thread Ion Alberdi
Hi Jörg! >At this point I think ArrayField should always use ARRAY constructor to benefit from the additional sanity checks. But as noted earlier, ARRAY also exposes this weird behavior: Definitely, FYI Daniele Varrazzo from psycopg2 said https://github.com/psycopg/psycopg2/issues/1507 that >ARRAY

Re: ArrayField: Bug on exact_nested_null

2022-10-11 Thread Jörg Breitbart
@Ion Well I am not deep enough into django's ArrayField for postgres to tell, which one is the desired output or right behavioral pattern. For my COPY FROM rewrite I simply tested several edge cases and tried to get as close as possible to ArrayField. From postgres side of things the followi

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread Ion Alberdi
>Imho the important bit > is, that ARRAY will drop the top level array to {} (empty array with no > dimension info), if there is at least one empty sub array declared with > ARRAY among NULLs, while if all sub entries are NULL the top level array > will still manifest with dimension info, but now w

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread Jörg Breitbart
Not sure if it is related, but the last sentence here caught my attention: > I wonder whether this is due to django or psycopg2. Indeed, the bug is > not reproduced > if at least one of the element in the nested array is not null. When doing a COPY FROM replacement of bulk_update for postgres I

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread Ion Alberdi
No pb & crystal clear, ticket created at https://code.djangoproject.com/ticket/34080#ticket thanks again Adam! Le lundi 10 octobre 2022 à 10:02:32 UTC+2, Adam Johnson a écrit : > Ah sorry didn't realize. > > I would just link to the test from your ticket for now, the fellows are > probably in a

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Ah sorry didn't realize. I would just link to the test from your ticket for now, the fellows are probably in a better position to determine how to treat this bug. On Mon, Oct 10, 2022 at 8:47 AM Ion Alberdi wrote: > Great, thanks Adam! FYI the test is already on django's Test suite > (https://g

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread Ion Alberdi
Great, thanks Adam! FYI the test is already on django's Test suite (https://github.com/pricemoov/django/pull/2/files) Would you like me to open a PR in Django or should I wait for the fix of the test being developed first? Le lun. 10 oct. 2022 à 09:39, 'Adam Johnson' via Django developers (Contri

Re: ArrayField: Bug on exact_nested_null

2022-10-10 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Yes please create a ticket. If you’re feeling brave, try to adapt your test into Django’s test suite (here: https://github.com/django/django/blob/84206607d6bfd61e7f7a88b51163ffd4153e3b5a/tests/postgres_tests/test_array.py#L212 )! On Sun, Oct 9, 2022 at 11:49 AM Ion Alberdi wrote: > Hello to all,

ArrayField: Bug on exact_nested_null

2022-10-09 Thread Ion Alberdi
Hello to all, a unit test added at https://github.com/pricemoov/django/pull/2 shows that the exact filter on a full "NULL nested array" currently fails. (the commit messages shows how to reproduce the error). More precisely, the error is "django.db.utils.DataError: invalid input syntax for type