Re: Adding SVN revision identifier to version

2007-08-20 Thread Adrian Holovaty
On 8/20/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > I opened ticket 5215[1] and added a patch that parses > django/.svn/entries. This has been tested on systems with both the > new version of the entries file and the old. Both seem to work fine. Thanks for your work on this, Deryck! I've chec

Re: Adding SVN revision identifier to version

2007-08-20 Thread Deryck Hodge
On 8/18/07, Sean Perry <[EMAIL PROTECTED]> wrote: > First line is the format version number of the entries file itself. > Versions >= 7 are no longer in XML format. As you can see, mine says > '8'. > > If it is XML, the structure should be: > > > > > Assuming I read subversion-1.4.4/subversi

Re: Adding SVN revision identifier to version

2007-08-17 Thread Sean Perry
On Aug 17, 2007, at 9:09 PM, Deryck Hodge wrote: > > > > On Aug 17, 2007, at 10:37 PM, Sean Perry <[EMAIL PROTECTED]> wrote: > >> >> On Aug 17, 2007, at 6:49 PM, Russell Keith-Magee wrote: >>> >>> At the very least, your patch would need to catch the inevitable >>> error. Better yet would be an a

Re: Adding SVN revision identifier to version

2007-08-17 Thread Graham Dumpleton
FWIW, easier to use 'svnversion' command than 'svn info' and parsing result. On Aug 18, 5:45 am, "Deryck Hodge" <[EMAIL PROTECTED]> wrote: > Hi, all. > > Reading the Django users list, I saw someone mention not knowing what > the "pre" meant in the version string returned by django-admin.py. > Th

Re: Adding SVN revision identifier to version

2007-08-17 Thread Collin Grady
Deryck Hodge said the following: > Certain (older?) versions of the entries file are XML. We would need > to figure out how many versions there are, which doesn't do much for > future proofing us. Perhaps only fall back to the client if the 4th line isn't a rev #? -- Collin Grady Appearan

Re: Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
On Aug 17, 2007, at 10:37 PM, Sean Perry <[EMAIL PROTECTED]> wrote: > > On Aug 17, 2007, at 6:49 PM, Russell Keith-Magee wrote: >> >> At the very least, your patch would need to catch the inevitable >> error. Better yet would be an approach that doesn't require an >> external call. Is there any

Re: Adding SVN revision identifier to version

2007-08-17 Thread Sean Perry
On Aug 17, 2007, at 6:49 PM, Russell Keith-Magee wrote: > > At the very least, your patch would need to catch the inevitable > error. Better yet would be an approach that doesn't require an > external call. Is there any other data source we can farm? Is there > anything we can easily glean from th

Re: Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
On Aug 17, 2007, at 8:49 PM, "Russell Keith-Magee" <[EMAIL PROTECTED] > wrote: > > On 8/18/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: >> >> On 8/17/07, James Bennett <[EMAIL PROTECTED]> wrote: >>> What does this accomplish that 'svn info' doesn't? >>> >> >> Well, nothing, really. :-) > > I'm

Re: Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
On Aug 17, 2007, at 8:49 PM, "Russell Keith-Magee" <[EMAIL PROTECTED] > wrote: > > On 8/18/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: >> >> On 8/17/07, James Bennett <[EMAIL PROTECTED]> wrote: >>> What does this accomplish that 'svn info' doesn't? >>> >> >> Well, nothing, really. :-) > > I'm

Re: Adding SVN revision identifier to version

2007-08-17 Thread Russell Keith-Magee
On 8/18/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > > On 8/17/07, James Bennett <[EMAIL PROTECTED]> wrote: > > What does this accomplish that 'svn info' doesn't? > > > > Well, nothing, really. :-) I'm with Deryck - In reality, it achieves nothing that can't be done easier with svn info, but I'

Re: Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
On 8/17/07, James Bennett <[EMAIL PROTECTED]> wrote: > > On 8/17/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > > So instead of 0.97-pre the version would be 0.97-pre-SVN-5919. This > > might help make it easier to track down what revision people are > > running since so many of us run off trunk.

Re: Adding SVN revision identifier to version

2007-08-17 Thread James Bennett
On 8/17/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > So instead of 0.97-pre the version would be 0.97-pre-SVN-5919. This > might help make it easier to track down what revision people are > running since so many of us run off trunk. This, of course, would > have no impact on official releases.

Re: Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
On 8/17/07, Dave Rowe <[EMAIL PROTECTED]> wrote: > > Are these people always pulling from SVN? Otherwise, it'd always show > SVN-Unknown, right? Especially if 'svn' isn't in the path. > My assumption is that, yes, the majority of users on a "pre" release are running from SVN. Is there any oth

Re: Adding SVN revision identifier to version

2007-08-17 Thread Dave Rowe
On Fri, 17 Aug 2007 14:45:01 -0500, "Deryck Hodge" <[EMAIL PROTECTED]> wrote: > > Hi, all. > > Reading the Django users list, I saw someone mention not knowing what > the "pre" meant in the version string returned by django-admin.py. > This made me think of version numbers more generally, and

Adding SVN revision identifier to version

2007-08-17 Thread Deryck Hodge
Hi, all. Reading the Django users list, I saw someone mention not knowing what the "pre" meant in the version string returned by django-admin.py. This made me think of version numbers more generally, and I wondered if others saw value in appending an SVN revision identifier on the version string.