Re: Add support for multiple file fields

2017-09-12 Thread Johannes
Ok, My patch is ready. Anyone cares to review to get it in before the deadline this weekend? https://github.com/django/django/pull/9011 Thanks -Joe -- Johannes Hoppe Fon: +49 331 2812 9869 1 Fax: +49 331 2812 9869 9 www.johanneshoppe.com Lennéstr. 19 14469 Potsdam USt-IdNr.: DE284754038 On

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
OK, I drafted an implementation for django.forms.FileField to support `multiple` as an argument. https://github.com/django/django/pull/9011 I would appreciate some feedback. If you like the design, I’ll try to add documentation and better tests tomorrow. Thanks -Joe :) -- Johannes Hoppe Fon:

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
There is another thing I just come across while working on the form implementation. I realised, that there are multiple ways to extend the ClearableFileInput to support multiple files. More specifically the clear checkbox. Should there be only one checkbox to clear all files or individual once t

Re: Add support for multiple file fields

2017-09-02 Thread Melvyn Sopacua
On Sat, Sep 2, 2017 at 10:37 AM, Adam Johnson wrote: > ArchiveField sounds a bit too specific for Django core, the most common case > for uploading multiple files would probably be to access them individually, > which it would prevent. Yeah, was on the fence on that one myself. The use cases are

Re: Add support for multiple file fields

2017-09-02 Thread Johannes Hoppe
Interesting, I love the discussion. I anticipated, that there are may different solutions and opinions regarding this topic. I will limit the implementation to `django.forms` for now and hope, that more people will voice their opinions regarding a model implementation once this becomes available

Re: Add support for multiple file fields

2017-09-02 Thread Adam Johnson
I agree with Melvyn on the first point. I don't think Django should include model fields that encourage denormalization by default (apart from JSONField etc which are built into the DB). A forms.MultiFileField would make sense but to make storage easy it should somehow translate into multiple rows

Re: Add support for multiple file fields

2017-09-02 Thread Melvyn Sopacua
I don't think a MultiFileField belongs in the model layer. You're violating normalization principles making updates, removals, counts etc, needlessly complex. >From the ModelForm perspective, I can certainly appreciate a multi file form field that I can tell to store each file as a new model insta

Re: Add support for multiple file fields

2017-08-31 Thread Tom Forbes
(I wrote a reply earlier and sent it, but it appears to have disappeared into /dev/null. Apologies if it comes through at some later date.) It seems adding a multiple kwarg and retrofitting it onto the existing FileField might not be the best idea. It might cause confusion with existing FileField

Re: Add support for multiple file fields

2017-08-31 Thread Johannes Hoppe
I tried to exclude my personal opinion and preference from the ticket description, to have an open discussion. So here goes my personal opinion: It seems odd to me that the FileField is limited to 100 characters. I could not find any reference to why the field was limited in the first place.

Add support for multiple file fields

2017-08-31 Thread Johannes Hoppe
Hi there! I already created a ticket regarding this matter, but I think this thicket requires some discussion prior to crafting a solution. https://code.djangoproject.com/ticket/28554 The django.db.models.FileField currently allows only to store a single file URL. This behavior seems outdated c