Re: Accepting foreignkey assignment by PK on QuerySet.update() (#11521)

2009-09-11 Thread Karen Tracey
On Fri, Sep 11, 2009 at 10:06 AM, Jerome Leclanche wrote: > > On Fri, Sep 11, 2009 at 5:03 PM, Karen Tracey wrote: > > Mentioning in the description that the fix may be a hack might not have > been > > the best idea. > > It's not "may", it's "I don't know". I'm not an ORM expert either, > hence t

Re: Accepting foreignkey assignment by PK on QuerySet.update() (#11521)

2009-09-11 Thread Jerome Leclanche
On Fri, Sep 11, 2009 at 5:03 PM, Karen Tracey wrote: > > Why doesn't it have a test? I'll write one then. > Mentioning in the description that the fix may be a hack might not have been > the best idea. It's not "may", it's "I don't know". I'm not an ORM expert either, hence the feedback reques

Re: Accepting foreignkey assignment by PK on QuerySet.update() (#11521)

2009-09-11 Thread Karen Tracey
On Fri, Sep 11, 2009 at 9:29 AM, Jerome Leclanche wrote: > > Could someone give some feedback on #11521? > (http://code.djangoproject.com/ticket/11521) > It's been sitting for almost 3 months without any kind of answer. The > current patch is a 2-line change which looks very reasonable, but I'd >

Accepting foreignkey assignment by PK on QuerySet.update() (#11521)

2009-09-11 Thread Jerome Leclanche
Could someone give some feedback on #11521? (http://code.djangoproject.com/ticket/11521) It's been sitting for almost 3 months without any kind of answer. The current patch is a 2-line change which looks very reasonable, but I'd love to be aware of any possible side effect of that change. J. Lecl