Re: 5 for 1?

2013-02-14 Thread peter
Thank you aaugustin for taking a look at https://code.djangoproject.com/ticket/13794. I've made some further updates but haven't heard anything back in a few weeks. Even though the original ticket title and description makes it sound like a fairly minor bug I do want to point out that as with m

5 for 1?

2013-01-28 Thread peter
Not sure if this is still a thing, but i'd like to ask for a review of this ticket: https://code.djangoproject.com/ticket/13794 I triaged/reviewed the following tickets: #18201, #19668, #19663, #19617, #19624 -- You received this message because you are subscribed to the Google Groups "Djang

Re: Anyone have time for a 5-for-1?

2012-10-03 Thread Anssi Kääriäinen
On 3 loka, 03:51, Stephen Burrows wrote: > I was hoping someone could have a look > at:*https://code.djangoproject.com/ticket/14567* Committed. > *https://code.djangoproject.com/ticket/11027* Some thoughts given in the ticket. I hope some core-dev w

Anyone have time for a 5-for-1?

2012-10-02 Thread Stephen Burrows
If there are any core devs with time for it, I'd like to cash in some triage. I've triaged: https://code.djangoproject.com/ticket/15338 https://code.djangoproject.com/ticket/16630 https://code.djangoproject.com/ticket/18413 https://code.djangoproject.com/ticket/12836 https://code.djangoproject.co

5 for 1

2011-06-27 Thread Michael Manfre
I reviewed: #16358 #16355 #16359 #16353 #16316 Please look at #15829 (https://code.djangoproject.com/ticket/15829). Thanks, Michael Manfre -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop

Re: 5-for-1?

2011-06-18 Thread Stephen Burrows
> > only partially. > > > Fortunately there is a good (new) convention in Django how to write kwarg > > style template parameters, thanks to Chris Beaven's with/include tag > > refactor > > (``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), whi

Re: 5-for-1?

2011-06-18 Thread Sam Bull
rg1 }}: {{ args2 }}{% endwith %}``), which > could also be used for the tag helpers. > > Jannis > >> On Jun 7, 12:24 pm, Carl Meyer wrote: >>> Hi Stephen, >>> >>> On 06/07/2011 02:37 AM, Stephen Burrows wrote: >>> >>>> Hi - i

Re: 5-for-1?

2011-06-18 Thread Jannis Leidel
arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which could also be used for the tag helpers. Jannis > On Jun 7, 12:24 pm, Carl Meyer wrote: >> Hi Stephen, >> >> On 06/07/2011 02:37 AM, Stephen Burrows wrote: >> >>> Hi - is the 5-for-1 deal still active o

Re: 5-for-1?

2011-06-18 Thread Julien Phalip
On Jun 18, 11:38 am, Stephen Burrows wrote: > I would love it if someone could look at 13956 [1] RFC'd, thanks ;) Julien -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.

Re: 5-for-1?

2011-06-17 Thread Stephen Burrows
oject.com/ticket/13956 On Jun 7, 12:24 pm, Carl Meyer wrote: > Hi Stephen, > > On 06/07/2011 02:37 AM, Stephen Burrows wrote: > > > Hi - is the 5-for-1 deal still active on ticket reviews? [1] > > If so, I've reviewed the following tickets: > > > 3624 > >

Re: 5-for-1?

2011-06-07 Thread Carl Meyer
Hi Stephen, On 06/07/2011 02:37 AM, Stephen Burrows wrote: > Hi - is the 5-for-1 deal still active on ticket reviews? [1] > If so, I've reviewed the following tickets: > > 3624 > 16152 > 16157 > 16158 > 16166 > > And would love it if someone could have a lo

5-for-1?

2011-06-07 Thread Stephen Burrows
Hi - is the 5-for-1 deal still active on ticket reviews? [1] If so, I've reviewed the following tickets: 3624 16152 16157 16158 16166 And would love it if someone could have a look at ticket 14082 [2]. If not, ah well. :-) Best, --Stephen Burrows [1] http://groups.google.com/group/d

Re: [5-for-1] Review request

2011-04-30 Thread Aymeric Augustin
Hello, I would like a core dev's opinion on #11555. The tickets I reviewed are listed here: http://myks.org/stuff/django_5-for-1.txt Thanks, -- Aymeric Augustin. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, se

Re: [5-for-1] Review request

2011-04-25 Thread Jonas H.
On 04/25/2011 05:33 PM, Jacob Kaplan-Moss wrote: On Mon, Apr 25, 2011 at 10:28 AM, Jonas H. wrote: I'd like you to look into http://code.djangoproject.com/ticket/15696. Done. Unfortunately, the result's probably not what you wanted. If you'd like to re-use your review wuffie I'd happily take

Re: [5-for-1] Review request

2011-04-25 Thread Jacob Kaplan-Moss
On Mon, Apr 25, 2011 at 10:28 AM, Jonas H. wrote: > I'd like you to look into http://code.djangoproject.com/ticket/15696. Done. Unfortunately, the result's probably not what you wanted. If you'd like to re-use your review wuffie I'd happily take a look at something else instead; just let me know.

[5-for-1] Review request

2011-04-25 Thread Jonas H.
Here's what I reviewed: http://code.djangoproject.com/ticket/15783 http://code.djangoproject.com/ticket/15774 http://code.djangoproject.com/ticket/15801 http://code.djangoproject.com/ticket/15896 http://code.djangoproject.com/ticket/15895 I'd like you to look into http://code.djangoproject.com/t

Re: [5-for-1] Review request

2011-04-22 Thread Gabriel Hurley
I noticed the "TODO" on the bottom of that page you linked... if you actually want to write something up for the docs about reviewing tickets (based on the discussion that's happened on the list the last few days) I'd suggest adding it to the /docs/howto/contribute section. Feel free to ping me

Re: [5-for-1] Review request

2011-04-22 Thread Jacob Kaplan-Moss
On Fri, Apr 22, 2011 at 3:26 AM, Aymeric Augustin wrote: > I have retroactively added 5 tickets for Alex's review, plus 5 tickets that > I'd like to trade against a review of #15255, especially the second comment. Done! BTW, I'm pretty sure Alex was joking about you needing to do five more, so d

Re: [5-for-1] Review request

2011-04-22 Thread Aymeric Augustin
2011/4/21 Alex Gaynor > As did I, do we have to retroactively require more reviews ;) > I'm now tracking my 5-for-1 deals here: http://myks.org/stuff/django_5-for-1.txt I have retroactively added 5 tickets for Alex's review, plus 5 tickets that I'd like to trade again

Re: [5-for-1] Review request

2011-04-21 Thread Alex Gaynor
On Thu, Apr 21, 2011 at 11:46 AM, Jacob Kaplan-Moss wrote: > On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin > wrote: > > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd > like > > someone to take a look at #14091. > > Done - thank you! I left comments on the ticket. > > J

Re: [5-for-1] Review request

2011-04-21 Thread Jacob Kaplan-Moss
On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin wrote: > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like > someone to take a look at #14091. Done - thank you! I left comments on the ticket. Jacob -- You received this message because you are subscribed to the Google

[5-for-1] Review request

2011-04-21 Thread Aymeric Augustin
Hello, I suggest we gather review requests on this thread to make the core devs' job easier (that is, until the thread becomes too long). I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like someone to take a look at #14091. Best regards, -- Aymeric Augustin. -- You rec