Re: 2 small tickets

2010-03-04 Thread Jared Forsyth
Is there a good tutorial/docs on "adding tests to django"? It took me a while to figure out/guess the structure/organization of tests, and I'm still not sure whether I've done it right (for reference here's the patchI

Re: 2 small tickets

2010-03-03 Thread Karen Tracey
On Wed, Mar 3, 2010 at 12:33 PM, Jared Forsyth wrote: > As a general "best practices" question: When I update a ticket w/ a test > case and better patch, do I uncheck 'needs better patch' and 'needs > testcases'? Or do I leave that to the person who originally checked them? > If you believe you h

Re: 2 small tickets

2010-03-03 Thread Jared Forsyth
As a general "best practices" question: When I update a ticket w/ a test case and better patch, do I uncheck 'needs better patch' and 'needs testcases'? Or do I leave that to the person who originally checked them? thanks, Jared On Wed, Mar 3, 2010 at 1:08 AM, Russell Keith-Magee wrote: > On Wed

Re: 2 small tickets

2010-03-03 Thread Russell Keith-Magee
On Wed, Mar 3, 2010 at 3:41 PM, Jared Forsyth wrote: > I found some bugs, wrote come patches, submitted some tickets. =) Is that > all that's needed? > The two patches I wrote are very small, one is only one char diff... > I guess I just want to know > a) have I done all that's required/suggested,

Re: 2 small tickets

2010-03-02 Thread Gert Van Gool
I believe you still need test cases for both tickets. -- Gert Mobile: +32 498725202 Web: http://gert.selentic.net On Wed, Mar 3, 2010 at 08:41, Jared Forsyth wrote: > I found some bugs, wrote come patches, submitted some tickets. =) Is that > all that's needed? > The two patches I wrote are v

2 small tickets

2010-03-02 Thread Jared Forsyth
I found some bugs, wrote come patches, submitted some tickets. =) Is that all that's needed? The two patches I wrote are *very* small, one is only one char diff... I guess I just want to know a) have I done all that's required/suggested, and b) if so, what's the expected turnaround time for very sm