Re: [Feature] On CommandError, sys.exit(1)

2015-10-27 Thread bliyanage
Hm, let me check it out and get back to you. We had some migrations that exited in failure, but with a non-0 exit status during our release. I'll see if I can reproduce this this week. -Ben On Monday, October 26, 2015 at 11:21:17 AM UTC-7, Tim Graham wrote: > > The place you linked to is igno

Re: [Feature] On CommandError, sys.exit(1)

2015-10-26 Thread Tim Graham
The place you linked to is ignoring CommandError when parsing arguments. I'm not sure under what conditions this happens (if at all) -- the Django tests don't cover it. As far as I know, BaseCommand already does sys.exit(1) when there's an unhandled exception: https://github.com/django/django/

Re: [Feature] On CommandError, sys.exit(1)

2015-10-26 Thread bliyanage
Is it ok if I do a PR on this? This seems like it would be really useful for automation. -Ben On Thursday, October 22, 2015 at 2:20:18 AM UTC-7, Ben Liyanage wrote: > > Hey, > > What do you guys think about this feature request? > > > On CommandError, sys.exit(1) > > It would be pretty easy to

[Feature] On CommandError, sys.exit(1)

2015-10-22 Thread Ben Liyanage
Hey, What do you guys think about this feature request? > On CommandError, sys.exit(1) It would be pretty easy to do the sys.exit(1) right here: https://github.com/django/django/blob/df0a446fd4c864c003e4f941b5b7abd6f10c9427/django/core/management/__init__.py#L289 This would allow you to fail a