Re: [5-for-1] Review request

2011-04-30 Thread Aymeric Augustin
Hello, I would like a core dev's opinion on #11555. The tickets I reviewed are listed here: http://myks.org/stuff/django_5-for-1.txt Thanks, -- Aymeric Augustin. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, se

Re: [5-for-1] Review request

2011-04-25 Thread Jonas H.
On 04/25/2011 05:33 PM, Jacob Kaplan-Moss wrote: On Mon, Apr 25, 2011 at 10:28 AM, Jonas H. wrote: I'd like you to look into http://code.djangoproject.com/ticket/15696. Done. Unfortunately, the result's probably not what you wanted. If you'd like to re-use your review wuffie I'd happily take

Re: [5-for-1] Review request

2011-04-25 Thread Jacob Kaplan-Moss
On Mon, Apr 25, 2011 at 10:28 AM, Jonas H. wrote: > I'd like you to look into http://code.djangoproject.com/ticket/15696. Done. Unfortunately, the result's probably not what you wanted. If you'd like to re-use your review wuffie I'd happily take a look at something else instead; just let me know.

[5-for-1] Review request

2011-04-25 Thread Jonas H.
Here's what I reviewed: http://code.djangoproject.com/ticket/15783 http://code.djangoproject.com/ticket/15774 http://code.djangoproject.com/ticket/15801 http://code.djangoproject.com/ticket/15896 http://code.djangoproject.com/ticket/15895 I'd like you to look into http://code.djangoproject.com/t

Re: [5-for-1] Review request

2011-04-22 Thread Gabriel Hurley
I noticed the "TODO" on the bottom of that page you linked... if you actually want to write something up for the docs about reviewing tickets (based on the discussion that's happened on the list the last few days) I'd suggest adding it to the /docs/howto/contribute section. Feel free to ping me

Re: [5-for-1] Review request

2011-04-22 Thread Jacob Kaplan-Moss
On Fri, Apr 22, 2011 at 3:26 AM, Aymeric Augustin wrote: > I have retroactively added 5 tickets for Alex's review, plus 5 tickets that > I'd like to trade against a review of #15255, especially the second comment. Done! BTW, I'm pretty sure Alex was joking about you needing to do five more, so d

Re: [5-for-1] Review request

2011-04-22 Thread Aymeric Augustin
2011/4/21 Alex Gaynor > As did I, do we have to retroactively require more reviews ;) > I'm now tracking my 5-for-1 deals here: http://myks.org/stuff/django_5-for-1.txt I have retroactively added 5 tickets for Alex's review, plus 5 tickets that I'd like to trade against a review of #15255, espe

Re: [5-for-1] Review request

2011-04-21 Thread Alex Gaynor
On Thu, Apr 21, 2011 at 11:46 AM, Jacob Kaplan-Moss wrote: > On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin > wrote: > > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd > like > > someone to take a look at #14091. > > Done - thank you! I left comments on the ticket. > > J

Re: [5-for-1] Review request

2011-04-21 Thread Jacob Kaplan-Moss
On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin wrote: > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like > someone to take a look at #14091. Done - thank you! I left comments on the ticket. Jacob -- You received this message because you are subscribed to the Google

[5-for-1] Review request

2011-04-21 Thread Aymeric Augustin
Hello, I suggest we gather review requests on this thread to make the core devs' job easier (that is, until the thread becomes too long). I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like someone to take a look at #14091. Best regards, -- Aymeric Augustin. -- You rec