Re: "getattr(): attribute name must be string"

2006-12-17 Thread [EMAIL PROTECTED]
It doesn't look like anything is being done with it right now. I believe the patch outlined in the code works but I haven't thoroughly tested it. I'd like to see it fixed too. If you need help, let me know. -Chris Phil Powell wrote: > I'm just wondering if anyone is following up on this issue

Re: Re: "getattr(): attribute name must be string"

2006-12-07 Thread Phil Powell
I'm just wondering if anyone is following up on this issue, as I've just been bitten by it? Or I'd happy to pull together some diff's and have a shot at some regression tests - but don't want to tread on anyone's toes? -Phil On 01/12/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > > On 1

Re: "getattr(): attribute name must be string"

2006-11-30 Thread Russell Keith-Magee
On 11/30/06, James <[EMAIL PROTECTED]> wrote: > > > Brian, splendid stuff :) Seems to work so far, at least in terms of > keeping database integrity and actually doing what it's supposed to. > Thanks very much for taking the time to post this solution. > > Now how do I write a regression test? Any

Re: "getattr(): attribute name must be string"

2006-11-30 Thread James
Waylan Limberg wrote: > Tests or not, be sure to post the fixes to the ticket (and perhaps a > link to this thread) so is doesn't get lost. It is done. -- James --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "D

Re: "getattr(): attribute name must be string"

2006-11-30 Thread Waylan Limberg
On 11/30/06, James <[EMAIL PROTECTED]> wrote: > > Brian, splendid stuff :) Seems to work so far, at least in terms of > keeping database integrity and actually doing what it's supposed to. > Thanks very much for taking the time to post this solution. Tests or not, be sure to post the fixes to the

Re: "getattr(): attribute name must be string"

2006-11-30 Thread James
Brian, splendid stuff :) Seems to work so far, at least in terms of keeping database integrity and actually doing what it's supposed to. Thanks very much for taking the time to post this solution. Now how do I write a regression test? Any docs available? -- James --~--~-~--~~--

Re: Re: "getattr(): attribute name must be string"

2006-11-30 Thread Russell Keith-Magee
On 11/30/06, James <[EMAIL PROTECTED]> wrote: > > > Any help you can provide in tracking the problem (and/or fixing > > it) would be greatfully accepted. > > I had a brief look at the code, and (despite my limited Python > knowledge) was going to pitch in if I could. Given Brian's detailed > respo

Re: Re: "getattr(): attribute name must be string"

2006-11-30 Thread Russell Keith-Magee
On 11/30/06, Brian Beck <[EMAIL PROTECTED]> wrote: > > Anyway, the key point is > that anything using get_accessor_name() should take None into account, > or None should never be returned. The former approach would be correct. get_accessor_name() shouldn't return a value if the m2m relation is sy

Re: "getattr(): attribute name must be string"

2006-11-30 Thread James
> Any help you can provide in tracking the problem (and/or fixing > it) would be greatfully accepted. I had a brief look at the code, and (despite my limited Python knowledge) was going to pitch in if I could. Given Brian's detailed response, I shall probably apply the fixes he suggests and spend

Re: "getattr(): attribute name must be string"

2006-11-29 Thread Brian Beck
ages/django/contrib/admin/views/main.py" in delete_stage 503. _get_deleted_objects(deleted_objects, perms_needed, request.user, obj, opts, 1) File "/usr/lib/python2.4/site-packages/django/contrib/admin/views/main.py" in _get_deleted_objects 464. rel_objs = getattr(obj, rel_opts_name, None)

Re: "getattr(): attribute name must be string"

2006-11-29 Thread Russell Keith-Magee
On 11/29/06, James <[EMAIL PROTECTED]> wrote: > > > This bug was submitted a couple of months ago: > > http://code.djangoproject.com/ticket/2828 > > but unfortunately I just got bitten by it :( Is there a fix, or will > one be forthcoming? Or is there a workaround (the one in the ticket > doesn't w

"getattr(): attribute name must be string"

2006-11-29 Thread James
This bug was submitted a couple of months ago: http://code.djangoproject.com/ticket/2828 but unfortunately I just got bitten by it :( Is there a fix, or will one be forthcoming? Or is there a workaround (the one in the ticket doesn't work, in fact)? TIA. -- James --~--~-~--~~