Re: #7210 - F() Query Expressions

2009-02-03 Thread Justin Bronn
> The main issue I flagged to Russell in some code review notes was > whether the code needed to be able to handle get_placeholder() output, > instead of hard-coding "%s" everywhere for parameters. If there were > particular column comparisons that required a more massaged approach to > getting th

Re: #7210 - F() Query Expressions

2009-02-01 Thread Malcolm Tredinnick
On Fri, 2009-01-30 at 20:30 -0800, Justin Bronn wrote: > > 2) F() expressions have not been updated to work with GIS fields. > > However, based on some initial discussions with Justin, it should be > > possible to make these changes without affecting any public API. If > > anyone with access and e

Re: #7210 - F() Query Expressions

2009-01-30 Thread Ian Kelly
On Fri, Jan 30, 2009 at 8:43 PM, Russell Keith-Magee wrote: > Can you clarify what you mean here - is it case of 'doesn't have these > operators in any form', or 'has these operators, but uses different > characters/functions? You answer this below for the bitwise operators, > but what about %? H

Re: #7210 - F() Query Expressions

2009-01-30 Thread Justin Bronn
> 2) F() expressions have not been updated to work with GIS fields. > However, based on some initial discussions with Justin, it should be > possible to make these changes without affecting any public API. If > anyone with access and experience with contrib.GIS cares to help out > on this front, a

Re: #7210 - F() Query Expressions

2009-01-30 Thread Russell Keith-Magee
On Sat, Jan 31, 2009 at 5:39 AM, Ian Kelly wrote: > > On Thu, Jan 29, 2009 at 4:14 AM, Russell Keith-Magee > wrote: >> >> Hi all, >> >> With [9792], I've committed F() query expressions to trunk. For >> details, see the docs: > > Hi Russell, > > First, my apologies for not testing this with Orac

Re: #7210 - F() Query Expressions

2009-01-30 Thread Alex Gaynor
On Fri, Jan 30, 2009 at 3:39 PM, Ian Kelly wrote: > > On Thu, Jan 29, 2009 at 4:14 AM, Russell Keith-Magee > wrote: > > > > Hi all, > > > > With [9792], I've committed F() query expressions to trunk. For > > details, see the docs: > > Hi Russell, > > First, my apologies for not testing this with

Re: #7210 - F() Query Expressions

2009-01-30 Thread Ian Kelly
On Thu, Jan 29, 2009 at 4:14 AM, Russell Keith-Magee wrote: > > Hi all, > > With [9792], I've committed F() query expressions to trunk. For > details, see the docs: Hi Russell, First, my apologies for not testing this with Oracle sooner. It appears that nobody else tested it either, because th

#7210 - F() Query Expressions

2009-01-29 Thread Russell Keith-Magee
Hi all, With [9792], I've committed F() query expressions to trunk. For details, see the docs: http://docs.djangoproject.com/en/dev/topics/db/queries/#filters-can-reference-fields-on-the-model There are two caveats worth knowing about: 1) This patch reveals a bug in the SQLite package that shi