Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 2:21 PM, Karen Tracey wrote: > FYI -- since this Windows Python 2.5.x problem doesn't appear to be > something we'll be able to figure out before I turn into a pumpkin and have > to go to sleep, and I'm not sure what you are thinking about with regard to > committing the c

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
FYI -- since this Windows Python 2.5.x problem doesn't appear to be something we'll be able to figure out before I turn into a pumpkin and have to go to sleep, and I'm not sure what you are thinking about with regard to committing the code -- the rest of the test suite runs normally on the Windows

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 10:20 PM, Russell Keith-Magee < freakboy3...@gmail.com> wrote: > On Thu, Jan 15, 2009 at 12:01 PM, Karen Tracey wrote: > > On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee > > wrote: > >> Next suggestion is to check if the converters that are registered on > >> lines

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 12:01 PM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: >> > Yeah, that's the direction I was heading in. Only I didn't have to go >> > so >> > far as trying against trunk.

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee wrote: > On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: > > Yeah, that's the direction I was heading in. Only I didn't have to go so > > far as trying against trunk. Even with the aggregate code, > > > Book.objects.filter(pk=1).v

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 11:26 AM, Alex Gaynor wrote: > > > On Wed, Jan 14, 2009 at 9:15 PM, Karen Tracey wrote: >> >> On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee >> wrote: >>> >>> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey >>> wrote: >>> > On Wed, Jan 14, 2009 at 7:22 PM, Russell

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: >> > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee >> > wrote: >> >> >> >> Help, yes. Illuminating, No. :-( >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Alex Gaynor
On Wed, Jan 14, 2009 at 9:15 PM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee < > freakboy3...@gmail.com> wrote: > >> >> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey >> wrote: >> > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee >> > wrote: >> >> >> >> Help,

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: > > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee > > wrote: > >> > >> Help, yes. Illuminating, No. :-( > >> > >> To fill you in on what I'm looking for - every aggregate

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee > wrote: >> >> Help, yes. Illuminating, No. :-( >> >> To fill you in on what I'm looking for - every aggregate value coming >> back from the database passes through resolve_aggregates() i

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee wrote: > Help, yes. Illuminating, No. :-( > > To fill you in on what I'm looking for - every aggregate value coming > back from the database passes through resolve_aggregates() in > django.db.models.query.py (line 212). This passes to convert_v

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 8:21 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 5:58 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: >> > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee >> > wrote: >> >> >> >> If you have any objections or probl

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 6:26 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 8:16 AM, Ian Kelly wrote: > > > > On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee > > wrote: > >> > >> On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly > wrote: > >>> > >>> On Wed, Jan 14, 2009 at 12:20 PM,

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 8:16 AM, Ian Kelly wrote: > > On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: >>> >>> On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: I'm seeing the same errors using the tarball snapshot. Al

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 5:58 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: > > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee > > wrote: > >> > >> If you have any objections or problem reports, speak now or live with > >> the consequences :-) > >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: >> >> On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: >>> I'm seeing the same errors using the tarball snapshot. All but the >>> last one are fixed by the attached patch. >> >>

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 4:33 PM, Ramiro Morales wrote: > Karen, > > On Wed, Jan 14, 2009 at 3:54 PM, Karen Tracey wrote: > > > > I'm getting some errors running the aggregation and aggregation_regress > > tests on Windows boxes running Python 2.5.2 and 2.5.4 when using sqlite > as > > the databa

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: > > On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: >> I'm seeing the same errors using the tarball snapshot. All but the >> last one are fixed by the attached patch. > > By "the last one" I actually mean the final failure where a float is >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee > wrote: >> >> If you have any objections or problem reports, speak now or live with >> the consequences :-) > > I'm getting some errors running the aggregation and aggregation_regress >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 4:20 AM, Ian Kelly wrote: > On Wed, Jan 14, 2009 at 10:54 AM, Karen Tracey wrote: >> I'm also seeing failures when using Oracle as the backend, many tracebacks >> that end with: >> >> File "d:\u\kmt\django\aggregation\django\db\backends\oracle\query.py", line >> 69, in co

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ramiro Morales
Karen, On Wed, Jan 14, 2009 at 3:54 PM, Karen Tracey wrote: > > I'm getting some errors running the aggregation and aggregation_regress > tests on Windows boxes running Python 2.5.2 and 2.5.4 when using sqlite as > the database.� I do not see these failures on these boxes using 'sqlite3' > backen

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: > I'm seeing the same errors using the tarball snapshot. All but the > last one are fixed by the attached patch. By "the last one" I actually mean the final failure where a float is expected but an int is seen. Ian --~--~-~--~~---

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 10:54 AM, Karen Tracey wrote: > I'm also seeing failures when using Oracle as the backend, many tracebacks > that end with: > > File "d:\u\kmt\django\aggregation\django\db\backends\oracle\query.py", line > 69, in convert_values > elif value is not None and field.get_in

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee < freakboy3...@gmail.com> wrote: > > If you have any objections or problem reports, speak now or live with > the consequences :-) > I'm getting some errors running the aggregation and aggregation_regress tests on Windows boxes running Python 2

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Jacob Kaplan-Moss
On Tue, Jan 13, 2009 at 9:52 PM, Russell Keith-Magee wrote: > I have now finished work on ticket #3566 - adding aggregations to Django's > ORM. Woohoo! Congratulations, and many thanks to you, Nicolas, and all the others who helped out. Jacob --~--~-~--~~~---~--~--

#3566 - Aggregations: Ready to commit

2009-01-13 Thread Russell Keith-Magee
Hi all, I have now finished work on ticket #3566 - adding aggregations to Django's ORM. I intend to commit the code to Django's trunk tomorrow evening, my time (i.e., in about 30 hours time). If you have any objections or problem reports, speak now or live with the consequences :-) Yours, Russ