Re: #31319 URL dispatcher does not handle multislashes

2020-03-04 Thread Adam Johnson
The nginx documentation points to a reason: https://nginx.org/en/docs/http/ngx_http_core_module.html#merge_slashes Note that compression is essential for the correct matching of prefix > string and regular expression locations. Without it, the > “//scripts/one.php” request would not match > >

Re: #31319 URL dispatcher does not handle multislashes

2020-03-04 Thread Bjoern Boschman
Hi Adam, APPEND_SLASH only adds a slash at the end of the path I'm more concerned about having multiple slashes in the middle of the path I get your point about canonical URLs - I'm just confused why other major HTTP servers are handling this different On Wednesday, 4 March 2020 14:27:19 UTC-5,

Re: #31319 URL dispatcher does not handle multislashes

2020-03-04 Thread Adam Johnson
I'd be against this Merging multiple slashes is a way of duplicating canonical URL's for things, something Django actively tries to avoid with APPEND_SLASHES. If you want this functionality you should be able to create it yourself with a custom URL converter or URLPattern subclass. On Wed, 4 Mar

#31319 URL dispatcher does not handle multislashes

2020-03-04 Thread Bjoern Boschman
Hi, I'd like to start a discussion about how django handles multiple slashes. see: https://code.djangoproject.com/ticket/31319#comment:1 So far I can confirm that nginx, apache and unix folders handle multiple slashes the same way (-> they get merged) What's your (dev) opinion on this? Cheers B