Default values for required and error css classes

2021-10-26 Thread smi...@gmail.com
Hi all, I was looking at the code for `forms.Form` recently and noticed that there are a couple of hooks[1] to add CSS classes to required or erroneous forms. However, the ​`BaseForm` does not have a class level initialisation of these. The classes are then later added via a `hasattr` check.

Re: Recognising Contributions

2021-08-18 Thread smi...@gmail.com
ithub.com/projects/flat-data >>>> * "A git query language" https://github.com/filhodanuvem/gitql >>>> * "git quick stats" https://github.com/arzzen/git-quick-stats >>>> >>>> I think there's plenty of tooling there to show how to get

Recognising Contributions

2021-06-29 Thread smi...@gmail.com
Hi all, I've had this sat in my drafts for a while. Rather than let it sit on the shelf any longer I thought it better to share. I've been thinking about recognising contributions recently. The main issue with the notes here is that it focuses on code rather than contributions to the wider

Re: Changing widget rendering templates

2021-06-06 Thread smi...@gmail.com
er >>> of projects using `as_p` &co somewhere is legion; just changing the HTML >>> would be a pretty big break without a fallback... 🤔 Whether it's worth the >>> disruption to formally deprecate and remove these methods I don't know... >>> We could add a

Changing widget rendering templates

2021-06-03 Thread smi...@gmail.com
Hey all, I've been looking at the couple of tickets open to improve accessibility of the forms and checkbox/radio widgets. [1][2] While changing the layout is _fairly_ straight forward I'm unsure how to transition to the new way. I'm focusing this change in changing the widget templates until

Easy Pickings

2021-02-10 Thread smi...@gmail.com
Hi all, tl;dr - I'm proposing we make more use of the 'easy pickings' flag on trac and should aim to have 20-30 tickets with this flag. More options here will hopefully help new contributors. If there is support, I'm happy to help review tickets to push the number up. I've been thinking abou

Re: Proposal to add pre-commit

2020-11-17 Thread smi...@gmail.com
Hi All, Thanks for your comments. Adam -- yes, I quite like pre-commit-hooks it reminds me of the 'pick and mix' when I was a kid. We can easily add more here, as I guess the risk is low. I like the idea of running the binaries through the system but I wonder if it's too much here. That is,

Proposal to add pre-commit

2020-11-06 Thread smi...@gmail.com
Hi All I have opened a ticket[1] which proposes to add pre-commit[2] to Django, and wish to gather thoughts on it here. For anyone not familiar pre-commit checks for simple issues before each `git commit`. The aim is to try and catch format errors closer to the developer and therefore reduce

Re: Proposal: Drop dependency on pytz in favor of zoneinfo

2020-10-08 Thread smi...@gmail.com
Hi All, While I understand the desire to have an early opt-in for some I think the important question here is the deprecation warnings. The recent URL() change showed that no matter how long there is a new way some?/many? folk won't change until they need to. Nick -- if we introduced a breaki