Re: Request to contribute in Django

2024-09-20 Thread Tim Graham
Hi Anant, https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ is a good place to start. On Monday, September 16, 2024 at 1:03:21 PM UTC-4 Anant Chitranshi wrote: > Dear All, > I am Anant Chitranshi. I wish to contribute to django. Can you please help > me to start? >

Re: [Question] Why BaseManager._get_queryset_methods need use getattr(self.get_queryset(), name) in create_method

2024-02-27 Thread Tim Graham
Hi Ryoma, a good way to investigate this would be to make the change and see if anything breaks. If I understand correctly, your suggest is: -return getattr(self.get_queryset(), name)(*args, **kwargs) +return method(*args, **kwargs) In that case, running the tes

Re: Transition Docs to Inline

2024-01-10 Thread Tim Graham
I don't think moving docs inline is a good idea. Quoting Aymeric from 2013 regarding django.contrib.admindocs [1] summarizes my feelings: """ 1) It's called the "documentation generator", but it only operates on docstrings. This promotes the idea that docstrings are appropriate documentation, w

Re: Transition Docs to Inline

2024-01-05 Thread Tim Graham
Hi Moshe, Why is consulting the online documentation insufficient? I think most developers build Django projects while referencing the online documentation rather than while reading Django's source code. What sort of documentation would be inlined? Would this require a large amount of duplica

Re: Can we move the activity on this list to the Forum now?

2023-05-04 Thread Tim Graham
I agree with Carsten. I find the groups.google.com web interface much easier to follow and to quickly scan and see which threads I've read and which have new activity. I follow this mailing list more closely than the forum and prefer writing to it. Incidentally, when I look at the "Django Inter

Re: Doc make error: make: *** [Makefile:59: html] Error 127

2023-04-10 Thread Tim Graham
It looks like Sphinx isn't installed. Did you `pip install docs/requirements.txt`? On Monday, April 10, 2023 at 9:12:48 AM UTC-4 Ezekiel Adetoro wrote: > I want to generate the documentation for Django, I have the folloe error > > sphinx-build -b djangohtml -n -d _build/doctrees -D language=en

Re: Opensource Django Project

2023-04-08 Thread Tim Graham
Yes. See https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ On Saturday, April 8, 2023 at 10:50:17 AM UTC-4 Naresh Pahariya wrote: > Me too... > > I think there is a documentation for django contribution. > > Thanks, > Naresh > > On Sat, 8 Apr, 2023, 3:51 pm Dipankar

Stalebot on djangoproject.com issues

2023-04-05 Thread Tim Graham
Hello, In October 2022, a stalebot was activated for djangoproject.com issues: https://github.com/django/djangoproject.com/issues/1219 https://github.com/django/djangoproject.com/pull/1220 It comments on an issue if there's no activity in the last six months: "This issue has been automatically

Re: Claiming Tickets

2023-01-28 Thread Tim Graham
Correct On Saturday, January 28, 2023 at 11:32:21 AM UTC-5 jonathan...@gmail.com wrote: > Hi all, > > I was reading up on the documentation for new contributors and was reading > the "Claiming Tickets" section where it says "If a ticket for this issue > already exists, make sure nobody else h

Re: Error

2023-01-22 Thread Tim Graham
Hi, You've found the wrong mailing list for this post. This mailing list is for discussing the development of Django itself, not for support using Django. This means the discussions of bugs and features in Django itself, rather than in your code using it. For support, please follow the "Getting

Re: Reverse for 'car_details' with arguments '('',)' not found. 1 pattern(s) tried:

2023-01-22 Thread Tim Graham
Hi, You've found the wrong mailing list for this post. This mailing list is for discussing the development of Django itself, not for support using Django. This means the discussions of bugs and features in Django itself, rather than in your code using it. For support, please follow the "Getting

Re: Request for Guidance

2023-01-17 Thread Tim Graham
Hello, please take a look at https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ to find advice for new contributors. On Tuesday, January 17, 2023 at 2:07:02 PM UTC-5 gair...@somaiya.edu wrote: > > > > > Hello sir, i am Gairick a second year MCA student and want t

Re: Proposal for a "RegExpMatches" PostgreSQL ORM function

2023-01-17 Thread Tim Graham
Hi, please consolidate your proposal when your ideas are complete. There's no need to start a separate thread for every function. Also, please search this mailing list and ticket tracker for past discussions that might be relevant. A quick search turned up at least https://groups.google.com/g/d

Re: GSOC 2023

2023-01-10 Thread Tim Graham
Hello all, please take a look at https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ to find advice for new contributors. On Tuesday, January 10, 2023 at 11:26:12 AM UTC-5 arpitasriv...@gmail.com wrote: > Hello Everyone , myself Arpita Srivastava a pre final year com

Re: Backport for ticket 34063?

2023-01-01 Thread Tim Graham
Incidentally, I don't think it's important for the ultimate decision here, but I looked at the below analysis of ticket #32189. Carlton's analysis on the ticket that request.POST is empty when using 'content-type': 'application/json' remains true. The results of the tests provided in the descri

Re: Backport for ticket 34063?

2023-01-01 Thread Tim Graham
-case basis, at least if there's no consensus on the mailing list. On Sunday, January 1, 2023 at 5:41:03 PM UTC-5 James Bennett wrote: > On Sun, Jan 1, 2023 at 12:54 PM Tim Graham wrote: > > Older Django releases are currently maintained with minimal support that > allows exist

Re: Backport for ticket 34063?

2023-01-01 Thread Tim Graham
Older Django releases are currently maintained with minimal support that allows existing projects to continue running securely. I don't think we should invest resources in promoting them as a place to use experimental features. A benefit of running an old LTS release like 3.2 is that any releas

Re: Backport for ticket 34063?

2022-12-30 Thread Tim Graham
As perfectionists, it's always hard to say (and hear) "no" when this sort of request comes up. I'm unconvinced it's a serious issue that requires a break from normal policy. (Unreported for 2 years in 4 major releases; simple workaround present.) Incidentally, escalating an issue to the steerin

Re: `call_command` raises ValueError during testing

2022-10-02 Thread Tim Graham
Hi Ferran, It looks like opt.option_strings is empty because "poll_ids" (in parser.add_argument()) isn't prefixed with a dash or double dash. You could instead use call_command() like this: call_command("closepoll", 1) But I think your invocation could be fixed (or at least not fail so obscur

Re: Model-level validation

2022-10-01 Thread Tim Graham
> Among the dozen of Django applications I have worked on, at 3 companies, not a single one was actually running any kind of validation. It has always been a mistake, 100% of the time, *never* the desired behavior. Besides not taking time to understand how Django works, it seems they weren't do

Re: PASSWORD_HASHERS Check

2022-06-25 Thread Tim Graham
st >> settings and be none the wiser. >> >> Also I think it's a good practice, you could have modified >> PASSWORD_HASHERS years ago, and the hasher that was once secure is not any >> more. >> >> On Tue, Jun 21, 2022 at 12:31 PM Tim Graham wro

Re: PASSWORD_HASHERS Check

2022-06-21 Thread Tim Graham
For context, Francisco proposed this at https://code.djangoproject.com/ticket/33793 which was marked wontfix by Mariusz with the comment: > Django keeps "weak" password hashers for support with legacy systems and ​speeding up the tests

Re: Proposals of GSOC.

2022-03-10 Thread Tim Graham
A proposal that was accepted last year is linked from https://code.djangoproject.com/wiki/SummerOfCode2022. On Wednesday, March 9, 2022 at 10:34:59 PM UTC-5 sarthak...@gmail.com wrote: > Can anyone share me old proposals of GSOC for django software application. > -- You received this message

Re: Why I'm not able to see any organization?

2022-03-08 Thread Tim Graham
I see it now... https://summerofcode.withgoogle.com/programs/2022/organizations/django-software-foundation-8o On Tuesday, March 8, 2022 at 8:23:22 AM UTC-5 sarthak...@gmail.com wrote: > Trying this from last night , is this with me or everyone is facing this > problem ? -- You received this m

Re: Proposal on how add configuration options to Email Backends

2022-01-29 Thread Tim Graham
The idea was pursued in https://code.djangoproject.com/ticket/22734 but ultimately abandoned. On Saturday, January 29, 2022 at 6:01:30 PM UTC-5 jacob...@gmail.com wrote: > This proposal attempts to address the following issues: > https://code.djangoproject.com/ticket/6989 (14 years old) > https:

Re: Roadmap and communication of features planned for releases

2022-01-29 Thread Tim Graham
Hi Jason, I'm not aware of any formally planned features. (If there were any, I'd expect they'd be discussed on this mailing list.) The next release will include whatever features the community contributes by the feature freeze deadline. See https://code.djangoproject.com/wiki/Version4.1Roadma

Re: Snowflake db backend

2021-12-04 Thread Tim Graham
Cedar Cares, Inc. funded me to write a Snowflake backend. The first alpha for Django 3.2 was released this week. Testers and feedback are welcome! https://github.com/cedar-team/django-snowflake https://pypi.org/project/django-snowflake/ I didn't find the implementation particularly onerous, but pe

Re: Violating unique constraint in the admin

2021-10-08 Thread Tim Graham
Hi, there have been some past discussions, e.g. https://groups.google.com/g/django-developers/c/Dju2vvbzECI/m/vYDnYekgBQAJ On Friday, October 8, 2021 at 6:34:02 AM UTC-4 Fab wrote: > Hi, > > When I violate a unique constraint in the admin I get an error page. > > I know I can check this myself a

Re: deconstruct returns 3-tuple?

2021-09-18 Thread Tim Graham
That documentation is for serializing classes. There's a note box that says, "This return value is different from the deconstruct() method for custom fields which returns a tuple of four items."

Re: Recognising Contributions

2021-08-18 Thread Tim Graham
I started including ticket numbers in patch releases because there aren't too many changes there and every change has a release note. I think the ticket numbers are useful to quickly identify the cause of some change or regression in a patch release where upgrades should generally be safer and

Re: datetime_safe deprecation

2021-08-01 Thread Tim Graham
Hi, did you consult the ticket? https://code.djangoproject.com/ticket/32738 On Sunday, August 1, 2021 at 1:09:04 PM UTC-4 mrhe...@gmail.com wrote: > I note that datetime_safe is to be removed in Django 5.0 >

Re: Paid Contributions for specific feature in Django

2021-04-20 Thread Tim Graham
Hi Taylor, As Adam said, it would be nice not to duplicate work that Disney's already done, but if I can help, I'm open to consulting and have written backends for CockroachDB (https://github.com/cockroachdb/django-cockroachdb) and Google Cloud Spanner (https://github.com/googleapis/python-spa

remove SECURE_BROWSER_XSS_FILTER setting?

2021-04-05 Thread Tim Graham
Hi, I think this setting and its functionality could be removed without a deprecation. Django's docs says, "Modern browsers don’t honor X-XSS-Protection HTTP header anymore. Although the setting offers little practical benefit, you may still want to set the header if you support older browsers.

Re: Test fails silently when using --tag

2021-04-05 Thread Tim Graham
This was fixed a week ago (will be in Django 4.0). https://code.djangoproject.com/ticket/29127 On Monday, April 5, 2021 at 5:18:45 AM UTC-4 Adam Johnson wrote: > Please don't report bugs here but to the ticket tracker. If you're not > sure there's a bug, django-users, the forum, or IRC are the

Re: Request for Comment: settings growth configuring Email Backend.

2021-04-02 Thread Tim Graham
I don't think there's a big cost to additional entries in docs/ref/setttings.txt. I think it's far more common to browse that document for needed functionality rather than to read the entire thing. There are 23 DATABASES 'TEST' settings that probably aren't used very frequently, yet I don't thi

Re: Request for Comment: settings growth configuring Email Backend.

2021-03-31 Thread Tim Graham
I don't think settings create any harm. They seem cleaner than suggesting subclassing the backend. If I'm understanding correctly, that would force everyone to write something like: class MySMTPBackend(smtp.EmailBackend) def __init__(self, *args, **kwargs): super().__init__(*args, ke

Re: Django 3.2rc1: models.W042 is raised on inherited manually specified primary key.

2021-03-25 Thread Tim Graham
Hi, It would be helpful to link to the ticket and/or explain the issue in more detail. On Thursday, March 25, 2021 at 9:28:09 AM UTC-4 Caram wrote: > > This issue was raised in alpha1, but I still had the issue in beta1 and > now also in rc1. > > As a result, I have to manually edit the migrati

Re: Help with ticket #28426

2021-03-04 Thread Tim Graham
I'd like to see what your code looks like so far. Personally, this is sounding a lot more complicated than I imagined when I accepted the ticket. I doubt this is a highly requested feature that couldn't be solved another way (e.g. downloading the template file without Django), and It's not clear

Re: New to the Community

2021-02-25 Thread Tim Graham
It's expected. Some tests are only applicable to certain databases. Search for all mentions of "skip" at https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/unit-tests/. You can run the tests with "-v 2" to see the reason why a test was skipped. On Thursday, February 25,

Re: Feature request: wigets attribute for ModelFormMixin class

2021-02-17 Thread Tim Graham
This has been proposed before (closed as wontfix): https://code.djangoproject.com/ticket/24589 https://groups.google.com/g/django-developers/c/34HJqx48h6Y/m/Nm3UMTK4BgAJ On Wednesday, February 17, 2021 at 9:53:07 AM UTC-5 jonask...@gmail.com wrote: > > # Feature request: wigets attribute for Mod

Re: Easy Pickings

2021-02-10 Thread Tim Graham
Hi David, I agree with your definition of easy as "ideal first issue" but I don't think aiming for a certain number of easy tickets makes sense. If those issues are quickly solved, then what happens... mark the next 20-30 easiest tickets? I'd say feel free to mark any tickets as "easy pickings"

Re: Deprecating django.utils.functional.cached_property() ?

2021-02-04 Thread Tim Graham
There's a ticket about it: https://code.djangoproject.com/ticket/30949 On Thursday, February 4, 2021 at 5:57:15 AM UTC-5 carlton...@gmail.com wrote: > functools.cached_property is available from Python 3.8. > > https://docs.python.org/3.9/library/functools.html#functools.cached_property > > Is

Re: Docs improvement? - MEDIA_URL in templates

2021-01-30 Thread Tim Graham
't tied to a File field (eg. Resized versions). So > the question remains: are the docs clear enough to explain how to do this? > > On Sat, 30 Jan 2021, 17:16 Tim Graham, wrote: > >> Hi Mike, >> >> I think you want to use {{ user.avatar.url }}. &g

Re: Docs improvement? - MEDIA_URL in templates

2021-01-30 Thread Tim Graham
Hi Mike, I think you want to use {{ user.avatar.url }}. https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.fields.files.FieldFile.url For future reference, since this is more of a usage question, it would be better to post to django-users. If you want to suggest a documen

Re: Revisiting Python support for after Django 3.2 LTS

2021-01-26 Thread Tim Graham
Looking at this again, I'm not sure it would be six versions. Carlton's suggested policy has the effect of dropping a lot of Python versions right before the LTS since it's supported for 3 years. For example, in Django 5.2 LTS, I think it's incorrect that Python 3.10 and 3.11 would be supported

Re: PR review request

2021-01-26 Thread Tim Graham
Hi William, 3.2 alpha marked the feature freeze. Only non-release blocking bug fixes may be backported at this point (from https://code.djangoproject.com/wiki/Version3.2Roadmap#schedule). There are 28 other patches in the review queue, many of which have been there longer than your tickets, so

Re: Rethink (?) how we handle security headers.

2021-01-24 Thread Tim Graham
quest): > response = self.get_response(request) > response["Cross-Origin-Embedder-Policy"] = "require-corp" > return response > > Also there are many non-security related headers one might want to add, so > having the ability to add t

Re: Snowflake db backend

2021-01-22 Thread Tim Graham
Hi Scott, Recently I've written backends for CockroachDB and Cloud Spanner. Perhaps those databases aren't as different as Snowflake, but I didn't have any major obstacles. I've had good success at contributing database backend API changes to Django to make future maintenance of those backends

Re: Polymorphics relationship

2021-01-21 Thread Tim Graham
Search the archives of this mailing list for "polymorphic" to see past discussions. There hasn't been consensus that it needs to be in Django itself. There's already https://django-polymorphic.readthedocs.io/en/stable/. On Thursday, January 21, 2021 at 3:41:13 PM UTC-5 jonnath...@gmail.com wrot

Re: Revisiting Python support for after Django 3.2 LTS

2021-01-20 Thread Tim Graham
Hi Carlton, This chart doesn't look quite right for the policy you wrote. For example, I wouldn't expect Django 4.2 LTS (supported until April 2026) to support Python 3.8 (only supported until October 2024). It seems like this policy makes it more likely that the last Django version to support a

Re: Permission to discuss

2021-01-19 Thread Tim Graham
django-users is suitable for that. This mailing list is limited to discussion of the development of Django itself. On Tuesday, January 19, 2021 at 4:56:47 PM UTC-5 Benny wrote: > Hi developers, > > I have an idea for a Django related project and I’d like to get input from > users and developers

Re: Rethink (?) how we handle security headers.

2021-01-19 Thread Tim Graham
> "PRELOAD": True, > "SECONDS": 1_000_000, > }, > } > > > On Tue, 19 Jan 2021 at 01:30, Tim Graham wrote: > >> The proposal seems to be a setting of the form: >> >> SECURITY_HEADERS = { >> 'Strict-Transpor

Re: Rethink (?) how we handle security headers.

2021-01-18 Thread Tim Graham
The proposal seems to be a setting of the form: SECURITY_HEADERS = { 'Strict-Transport-Security': 'max-age=60; includeSubDomains; preload', ... } Currently we have system checks to suggest setting SECURE_HSTS_SECONDS, SECURE_HSTS_PRELOAD, etc. Do you envision trying to keep these checks

Re: Adding Origin header checking to CSRF middleware (#16010)

2021-01-12 Thread Tim Graham
OWASP Cheat Sheet says, "It is important to note that [the SameSite Cookie] attribute should be implemented as an additional layer *defense in depth* concept. This attribute protects the user through the browsers supporting it, and it contains as well 2 ways to bypass it as mentioned in the fol

Adding Origin header checking to CSRF middleware (#16010)

2021-01-11 Thread Tim Graham
Hello, I've updated this 10 year old patch but some more changes are needed. I'll target it for Django 4.0. https://code.djangoproject.com/ticket/16010 https://github.com/django/django/pull/13829 Here are a few design decisions and questions that have come up: 1. It seems the main reason this w

Re: Technical Board Decision Needed: Admin append_slash behaviour.

2021-01-07 Thread Tim Graham
I wouldn't object to a wontfix. It seems like we've already spent a lot of effort here for little benefit, if any. On Thursday, January 7, 2021 at 8:16:57 AM UTC-5 carlton...@gmail.com wrote: > OK, thanks all. So... > > Two new options then: > > 1. Add the catch-all view to admin to stop the un

Re: Technical Board Decision Needed: Admin append_slash behaviour.

2021-01-06 Thread Tim Graham
As a non-technical board member, I'd prefer option 1. I also think that for most use cases, staff users are at least somewhat trusted and even if they are not, model enumeration isn't likely to be a security problem. On Wednesday, January 6, 2021 at 5:07:44 AM UTC-5 carlton...@gmail.com wrote:

Re: SynchronousOnlyOperation: bug or misconfiguration?

2020-12-18 Thread Tim Graham
Hi, this mailing list isn't appropriate for "is it a bug?" questions. Please use django-users instead. On Friday, December 18, 2020 at 11:00:30 AM UTC-5 Federico Capoano wrote: > I have a celery task which performs queries and network operations. > > When deployed with celery with gevent concurr

Re: App label with dot

2020-12-18 Thread Tim Graham
app_label "should be a valid Python identifier." Dots aren't allowed. https://docs.djangoproject.com/en/stable/ref/applications/#django.apps.AppConfig.label On Friday, December 18, 2020 at 10:47:45 AM UTC-5 Federico Capoano wrote: > Defining the app_label of an AppConfig with a dot, like "myproj

Re: Proposal: Make the domain part of the Email Message-ID configurable

2020-12-07 Thread Tim Graham
You don't need to announce a patch on the mailing list. Instead check "According to the ticket's flags , the next step(s) to move this issue forward are" on the ticket and update it accordingly. Tha

Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Tim Graham
implement the PR with a comment instead of a warning. > > Le mar. 1 déc. 2020 à 16:18, Tim Graham a écrit : > >> Please try to make it easy to understand the issue without looking at >> tickets and pull requests. Even after I did that, I couldn't find why you >> be

Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Tim Graham
Please try to make it easy to understand the issue without looking at tickets and pull requests. Even after I did that, I couldn't find why you believe it should be a warning and not a comment. Why is this situation different from all the other places Django uses comments to indicate where intr

Re: Revisiting Python support for after Django 3.2 LTS

2020-11-24 Thread Tim Graham
Dropping support for Python versions as they go EOL in existing Django releases would be disruptive. Distros "support" Python versions longer than the PSF does. If a Django version inadvertently breaks compatibility with an old version of Python because we stop testing with it, we'll get bug re

Re: Hello Everyone

2020-11-23 Thread Tim Graham
Hi Vineet, this is an extremely common question on this mailing list. Please search the archives for something like "contribute to django" and you'll see many answers. Have fun! On Monday, November 23, 2020 at 8:40:47 AM UTC-5 vinee...@gmail.com wrote: > I am Vineet Sharma, pursing computer sci

Re: Revisiting Python support for after Django 3.2 LTS

2020-11-21 Thread Tim Graham
Part of the rationale for dropping Python versions after an LTS is was to avoid getting "stranded" on a non-LTS version of Django. For example, if we keep Python 3.7 support in Django until Python 3.7 is end of life in June 2023, that would probably make Django 4.1 the latest version to support

Re: Adding a security concerned feature

2020-11-18 Thread Tim Graham
I'm not convinced that a system check promoting security by obscurity adds much value. The original poster wrote "sometimes it can be a security concern." Maybe that's the case (how so?) but for most sites I would say it's not. On Wednesday, November 18, 2020 at 7:33:47 AM UTC-5 Carles Pina Esta

Re: Primary Key AutoField -> UUID Field

2020-11-14 Thread Tim Graham
Hi Brian, There are existing threads about that (try searching the archives for 'default pk' to find some of them). Here's a PR that adds the setting you described: https://github.com/django/django/pull/13179. Perhaps you would like to try it out and see if it meets your needs. On Saturday, Nov

Re: Advancing with the Triage & Review Team idea.

2020-10-05 Thread Tim Graham
t;> review from me. This has been very helpful, and quite smooth. (It’s in a >> similar vein to marking tickets on Trac Ready for Commit, which also helps >> them to show about the mass.) >> >> Ultimately I think a Triage & Review Team is an opportunity to widen the

Re: Proposal: Make the domain part of the Email Message-ID configurable

2020-09-06 Thread Tim Graham
Hi, I think https://code.djangoproject.com/ticket/6989 has some discussion related to this. On Sunday, September 6, 2020 at 7:30:15 AM UTC-4 jacob...@gmail.com wrote: > When Django's mail subsystem generates an email, it creates a unique > Message-ID. This is a requirement specified in RFC2822.

Re: Updates to PR are not reflected in Jenkins, checks failing

2020-08-31 Thread Tim Graham
Hi, I'd try rebasing your branch against master to eliminate the merge conflict. On Monday, August 31, 2020 at 4:37:15 PM UTC-4 ba...@google.com wrote: > Hi All! > > I have an open PR and am > having difficulty getting the Jenkins checks to pass. I

Re: Make tag name a variable in form templates

2020-07-24 Thread Tim Graham
My point is that if Django used variables for tag names in its widget templates, it would suggest developers write code that's inconsistent with Django's design philosophy. As was pointed out with things like the 'type' attribute, these templates aren't meant to be generic templates for web com

Re: Make tag name a variable in form templates

2020-07-24 Thread Tim Graham
A datepicker is rather different from a plain TextInput widget so I think it's good design to use a separate widget. If Django provided datepicker functionality, I'm fairly sure it would be provided as a separate widget rather than instructing users to use something like forms.TextInput(tag='du

Re: Make tag name a variable in form templates

2020-07-24 Thread Tim Graham
For me, a custom widget (that could use its own template) looks cleaner. Something like birth_date=DatePicker() seems more readable and doesn't require repeating "tag='duet-date-picker'"" each time. If you prefer your one-line version, you could override the input.html template and make the tag

Re: Should the docs suggest namespace packages?

2020-07-19 Thread Tim Graham
ing time. > > -- > Aymeric. > > > On 19 Jul 2020, at 22:25, Tim Graham wrote: > > On the topic of namespace packages, I noticed this line in the 3.1 release > notes: "Migrations are now loaded also from directories > without __init__.py files." https://code.djangopro

Re: Should the docs suggest namespace packages?

2020-07-19 Thread Tim Graham
On the topic of namespace packages, I noticed this line in the 3.1 release notes: "Migrations are now loaded also from directories without __init__.py files." https://code.djangoproject.com/ticket/30300 The ticket's rationale seems to be "We've just finished migrating our codebase to all-pytho

Re: Making startproject's settings more 12-factor-y

2020-06-27 Thread Tim Graham
Here's an unsuccessful attempt to defer the SECRET_KEY check: https://code.djangoproject.com/ticket/29324 It seems like it could be insecure to move that to a system check as "For performance reasons, checks are not run as part of the WSGI stack that is used in deployment." (Also, it seems impo

Re: Making startproject's settings more 12-factor-y

2020-06-05 Thread Tim Graham
Have you read past discussions on the mailing list? For example: Making Django more PaaS-friendly https://groups.google.com/d/topic/django-developers/BAGhOKXGj4I/discussion Searching the archives for "12-factor" yields some other results. That may help you to craft your proposal. On Friday, Ju

Re: Implement QuerySet.__contains__?

2020-06-05 Thread Tim Graham
(You can reopen https://code.djangoproject.com/ticket/24141 rather than creating a new ticket.) On Friday, June 5, 2020 at 9:06:48 AM UTC-4, Aymeric Augustin wrote: > > If people agree QuerySet.contains() should be added, how do we move > forward? > > > Yes, if there's no major new argument in a

Re: Implement QuerySet.__contains__?

2020-06-02 Thread Tim Graham
o the behavior change) On Tuesday, June 2, 2020 at 8:53:07 AM UTC-4, Tim Graham wrote: > > It may help to know that QuerySet.__contains__() was implemented until > Django 1.6 when chunked reads were removed from QuerySet iteration: > > > https://github.c

Re: Implement QuerySet.__contains__?

2020-06-02 Thread Tim Graham
It may help to know that QuerySet.__contains__() was implemented until Django 1.6 when chunked reads were removed from QuerySet iteration: https://github.com/django/django/commit/70679243d1786e03557c28929f9762a119e3ac14 On Tuesday, June 2, 2020 at 7:43:25 AM UTC-4, Aymeric Augustin wrote: > > O

Re: Adding json lines (jsonl) serializer to django

2020-05-21 Thread Tim Graham
Hi Ali, as I noted on the PR, the ticket isn't in the review queue because "needs tests" is checked. On Thursday, May 21, 2020 at 9:47:53 AM UTC-4, Ali Vakilzade wrote: > > Hi! > > A while back I opened a pull request on this topic and there is no updates > on the my request for a while. I know

Re: Disabling .delete() in querysets in Django

2020-05-20 Thread Tim Graham
Hi Uri, I think you've mostly come across documented behaviors rather than "problems". You haven't provided enough details in the bug report to say for sure on that issue. I don't think the things you've implemented are generally applicable to many Django projects such that they warrant the ad

Re: Proposal: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields

2020-05-15 Thread Tim Graham
I'm in favor of the change. It seems to me that most slugs I see these days have stop words in them and they read better because of that. I don't think JavaScript warnings would be helpful. A release note is sufficient. Admin users still get a preview of the slug and can edit it if needed. On F

Re: Loading lzma compressed fixtures

2020-05-09 Thread Tim Graham
Hi Paolo, Please don't ask for code reviews on this mailing list. It just adds noise. Patches are reviewed from "Patches needing review" at https://dashboard.djangoproject.com/. At this time there are ~30 patches in the queue. Requesting your feature to be moved to the front of the review queue

Re: Swappable sessions

2020-04-15 Thread Tim Graham
uestion is: would it be okay to formally ask that the request object, > which is already available there, be passed to that method when called, > like " create_model_instance(self, data, request=None)"? > > El miércoles, 15 de abril de 2020, 17:01:30 (UTC-4), Tim Graham escrib

Re: Swappable sessions

2020-04-15 Thread Tim Graham
Can't you copy whatever data you want from the request into the session data (request.session. = request.) in a view, middleware, or wherever? That seems like the proper separation of concerns. On Wednesday, April 15, 2020 at 11:50:13 AM UTC-4, Lorenzo Peña wrote: > > Now, in order to follow the

Re: Proposal to not implicitly create varchar/text-pattern opclass indexes on PostgreSQL

2020-04-13 Thread Tim Graham
I have some sympathy for this issue as I'm trying to make the createcachetable management command use SchemaEditor rather than some custom SQL construction logic*. The related problem I ran into is that the primary key column (a CharField) uses unique=True which means those undesired opclasses

Re: handle_uncaught_exception error logging

2020-04-12 Thread Tim Graham
The relevant commit might be https://github.com/django/django/commit/10b44e45256ddda4258ae032b8d4725a3e3284e6. That change was made in Django 2.1. You didn't say what version of Django you're using. You'll have to give more details about your case and what's behaving differently. On Sunday,

Re: Adding ability to choose AutoField type (signed vs unsigned)

2020-04-09 Thread Tim Graham
How would the strategy of having a setting generate new migrations work with third-party apps? Generally migrations can't easily be added to them by user projects and if more migrations are added to the third party app in a later version, there will be an inconsistent history. On Thursday, Apri

Re: Does "Someday/Maybe" triage stage imply a low change of pull request getting merged?

2020-04-08 Thread Tim Graham
Generally "Someday/Maybe" tickets aren't ready for coding. Something else needs to happen first, perhaps a discussion on this mailing list to come to a consensus on how to proceed, or in the cast of that ticket (perhaps), the spec to be approved. On Wednesday, April 8, 2020 at 2:56:44 PM UTC-4,

Re: verbose_name used inconsistently in contrib.admin

2020-04-07 Thread Tim Graham
Hi, This behavior looks correct. Field names are used when displaying a model's fields, so a model's verbose_name doesn't have any effect there. Consider a model that has a two foreign keys to the same model. Displaying the model name in that case wouldn't allow distinguishing between the field

Re: Improve migration conflict detection

2020-02-18 Thread Tim Graham
Have you considered what would happen if a migration has a RunPython or RunSQL? They may require a certain model state. On Tuesday, February 18, 2020 at 12:08:03 PM UTC-5, caio wrote: > > I’m working on this as a standalone PoC app for now, I may be able to > share a repository with the code soo

Re: Relax system check on fields intermediary tables for db_table collision when database routers are installed

2020-02-13 Thread Tim Graham
The change for that ticket is already released. Please open a new ticket. On Thursday, February 13, 2020 at 9:00:35 AM UTC-5, Anonymous Rabbit wrote: > > Before I move forward I just to want clarify, my changes are for the same > check specified in ticket #29092. Should I still open a new ticket

Re: Announcing CockroachDB support for Django ORM

2020-01-27 Thread Tim Graham
This is the mailing list for the development of Django itself. Please use django-users for messages like this. On Monday, January 27, 2020 at 4:27:01 PM UTC-5, Charlotte Dillon wrote: > > https://pypi.org/project/django-cockroachdb/ > -- You received this message because you are subscribed to t

Re: Getting error while running tests for postgis

2020-01-23 Thread Tim Graham
Actually, this is somewhat on topic as it involves running the Django test suite. To solve the failure, add this to your test settings: PASSWORD_HASHERS = [ 'django.contrib.auth.hashers.MD5PasswordHasher', ] It seems like a bug that that test assumes MD5PasswordHasher. As for the skipped t

Re: [Feature Request] Allow a Field/DeferredAttribute object everywhere a field name as a string is currently expected

2020-01-13 Thread Tim Graham
If I understand correctly, currently this works: Question.objects.order_by(Question.pub_date.field_name) but your proposal is to avoid the need for ".field_name". I don't think I'd use that syntax as its more verbose and less readable (to me, anyway). Having more than one way to write things (s

Re: Worth raising a warning when `order_by('?')` is used with specific backends?

2020-01-10 Thread Tim Graham
I think issuing a warning would be rude to developers who want to use that feature and are aware of the limitation... they would have to do extra work to silence the warning. On Friday, January 10, 2020 at 10:14:23 AM UTC-5, Santiago Basulto wrote: > > Sadly I have to admit that I'm not involved

Re: Best Profanity filters for using in Python Django project

2019-12-26 Thread Tim Graham
Hi, I see you also posted to django-users. Please don't cross post to django-developers as this mailing list is about developing Django, not discussing usage questions. On Thursday, December 26, 2019 at 12:47:54 PM UTC-5, Unprofessional coder wrote: > > I have a requirement where I need to use

Re: Allow overriding smtplib local_hostname

2019-12-20 Thread Tim Graham
Hi, there's already a ticket: https://code.djangoproject.com/ticket/6989 On Friday, December 20, 2019 at 7:33:35 AM UTC-5, David Nolan wrote: > > Hey all. > > In cloud environments, when using > django.core.mail.backends.smtp.EmailBackend, socket.getfqdn() is called > to resolve the 'reported ho

Re: Removing old branches from the Django Git repository.

2019-10-10 Thread Tim Graham
Same proposal from 2016: https://groups.google.com/d/topic/django-developers/sf2adeIAkQA/discussion On Thursday, October 10, 2019 at 4:09:24 PM UTC-4, Tom Forbes wrote: > > I second this, there are a few other branches in that list (successful or > not) that have historic value to Django. Is the

  1   2   3   4   5   6   7   8   9   10   >