Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
s. > > Albert O'Connor > > > On Sun, Mar 24, 2013 at 7:10 AM, Russell Keith-Magee < > russ...@keith-magee.com> wrote: > >> >> On Sun, Mar 24, 2013 at 6:28 PM, Omer Katz wrote: >> >>> You are contradicting yourself. At first you said th

Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
2013/3/24 Russell Keith-Magee > > On Sun, Mar 24, 2013 at 6:28 PM, Omer Katz wrote: > >> You are contradicting yourself. At first you said that it does make the >> code clearer. Now you say it doesn't. >> > > My apologies -- I've apparently used an E

Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
> settings are handled in Django. There hasn't really been any work in this > area beyond some high level talks at DjangoCon etc [1], but adding > additional complexity to Django's already complex settings system isn't > something we're racing to do without a *r

Re: Changes to django's settings module

2013-03-23 Thread Omer Katz
So is my example good enough? Have you tried using it? בתאריך יום שישי, 15 במרץ 2013 13:17:11 UTC+3, מאת Aymeric Augustin: > > On 15 mars 2013, at 09:22, Omer Katz > > wrote: > > > Doesn't the fact that the patch makes the code clearer is a reason > enough for

Re: GeoDjango and __within query when IDL is involved

2013-03-18 Thread Omer Katz
s anyone know of a native GeoDjango solution to this? > > If not, would there be a lot of resistance against a patch that > incorporates this functionality in GeoDjango? > > > Val > Sent from my mobile device. > > On 2013-03-17, at 12:39 AM, Omer Katz > > wrote:

Re: Changes to django's settings module

2013-03-16 Thread Omer Katz
correctly. Are you guys still not convinced? 2013/3/16 Omer Katz > Shai, > The google groups editor is kinda annoying. I'll be using GMail from now > on because it removes formatting on random basis (I don't really know why) > > Also, I can rewrite django-configuartion i

Re: Changes to django's settings module

2013-03-16 Thread Omer Katz
progress. 2013/3/15 Aymeric Augustin > On 15 mars 2013, at 09:22, Omer Katz wrote: > > > Doesn't the fact that the patch makes the code clearer is a reason > enough for a merge (providing that there will be tests attached to it and > documentation)? > > > H

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
production package) and split the settings themselves by topic through different modules if you want to. בתאריך יום שישי, 15 במרץ 2013 11:14:31 UTC+3, מאת Russell Keith-Magee: > > > On Fri, Mar 15, 2013 at 3:36 PM, Omer Katz > > wrote: > >> Why would you call them magic?

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
t will help you achieve your desired settings structure much more easily? בתאריך יום שישי, 15 במרץ 2013 11:14:31 UTC+3, מאת Russell Keith-Magee: > > > On Fri, Mar 15, 2013 at 3:36 PM, Omer Katz > > wrote: > >> Why would you call them magic? >> Why does allowing extensibilit

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
-configurations, and suddenly every setting > can be overridden from the environment!" This seems like a bad idea, versus > "Install django-configurations, and now you have a new tool in your toolbox > to put in settings.py that imports from the environment!" > > Best

Re: Changes to django's settings module

2013-03-14 Thread Omer Katz
Also don't you guys think that the SettingsCollector class will simplify the implementation of django-configurations for example? בתאריך יום רביעי, 13 במרץ 2013 19:27:02 UTC+3, מאת Omer Katz: > > Lately I implemented some changes for django's settings module . > I refactored

Re: Changes to django's settings module

2013-03-14 Thread Omer Katz
I see much benefit in this refactoring and I hope that it will be accepted. I hope I made my intentions clearer. בתאריך יום רביעי, 13 במרץ 2013 19:27:02 UTC+3, מאת Omer Katz: > Lately I implemented some changes for django's settings module . > I refactored the whole module in order

Changes to django's settings module

2013-03-13 Thread Omer Katz
Lately I implemented some changes for django's settings module . I refactored the whole module in order to have more extension points. With #20040 it is now possible to inject the Settings class that will be used by the LazySettings object and I intro