Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-08-20 Thread Mike Edmunds
ago, and that probably needs to be resolved before we'd want to merge the second PR.) - Mike On Saturday, July 6, 2024 at 12:18:22 PM UTC-7 Mike Edmunds wrote: > Ticket created: https://code.djangoproject.com/ticket/35581 > > On Friday, July 5, 2024 at 5:27:28 PM UTC-7 Mike Edmunds

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-22 Thread Mike Edmunds
implementation of this upgrade > and are excited about the enhancements it will bring to our project. Please > let us know the next steps and how we can assist in the process. > > Thank you once again for your proposal and for your continued support. > > Best regards, >

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-06 Thread Mike Edmunds
On Saturday, July 6, 2024 at 11:17:35 AM UTC-7 Florian Apolloner wrote: On Saturday, July 6, 2024 at 12:30:32 AM UTC+2 Mike Edmunds wrote: Incidentally, I thought there was (used to be?) a policy that internal undocumented APIs were fair game for use by third-party libraries, subclassing

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-06 Thread Mike Edmunds
Ticket created: https://code.djangoproject.com/ticket/35581 On Friday, July 5, 2024 at 5:27:28 PM UTC-7 Mike Edmunds wrote: > Thanks to everyone for the feedback so far. > > It looks like all the responses to date are generally positive, and I > haven't seen any objections, so

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-05 Thread Mike Edmunds
Thanks to everyone for the feedback so far. It looks like all the responses to date are generally positive, and I haven't seen any objections, so I'm going to open a ticket. (Of course, additional feedback—positive or negative—and advice is very much appreciated.) Cheers, Mike -- You receive

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-05 Thread Mike Edmunds
About MIMEBase attachments: I propose we continue supporting them in Django, without deprecation, for now. We can investigate adding support for the equivalent in Python's modern email API later, as a separate proposal. More details… On Wednesday, June 26, 2024 at 6:28:06 PM UTC-7 I wrote: > Tr

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-07-05 Thread Mike Edmunds
On Friday, June 28, 2024 at 1:07:35 PM UTC-7 Florian Apolloner wrote: > Are all of those documented? If not we can simply remove them (especially if the deprecation implementation turns out to be a PITA). It sort of depends on the definition of "documented." I've dug into real-world usage; resul

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-06-27 Thread Mike Edmunds
t; knowledge on the topic is a bit lacking. > > Tom > > On Thu, 27 Jun 2024 at 03:28, Mike Edmunds wrote: > >> Since the early feedback seems positive (though we're still waiting for >> more votes), here's some additional detail on the changes I think would be

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-06-26 Thread Mike Edmunds
Since the early feedback seems positive (though we're still waiting for more votes), here's some additional detail on the changes I think would be involved to update django.core.mail to use Python's modern email API. (See my earlier message

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-06-25 Thread Mike Edmunds
that this is a good proposal -- this would modern > transactional email sending. > > - Arthur > > > On Mon, Jun 24, 2024 at 3:14 PM Mike Edmunds wrote: > > > Would this be designed to be compatible with "Proposal 14: Background > Workers"? > > I woul

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-06-25 Thread Mike Edmunds
. > > Apart from not having to deal with low-level email API stuff (which is a > pain IMHO), it provides lots of neat improvements I had to (re-)invent in > every project I was working on. > > What do you people think about this? I got quite good feedback in Vigo and > in my

Re: Proposal to upgrade django.core.mail to Python's modern email API

2024-06-24 Thread Mike Edmunds
n Python's smtplib. If any of it is still needed for SMTP, I'd probably want to move that code into the SMTP EmailBackend(s). - Mike On Sunday, June 23, 2024 at 10:22:03 PM UTC-7 Arthur Pemberton wrote: > Would this be designed to be compatible with "Proposal 14: Background >

Proposal to upgrade django.core.mail to Python's modern email API

2024-06-23 Thread Mike Edmunds
I want to propose updating django.core.mail to replace use of Python's legacy email.message.Message (and other legacy email APIs) with email.message.EmailMessage (and other modern APIs). If there's interest, I can put together a more detailed proposal and/or ticket, but was hoping to get some

Re: Should ugettext_lazy return instanceof unicode? Or are reusable apps responsible for calling force_text a lot?

2016-10-24 Thread Mike Edmunds
cause all kinds of downstream problems. On Sunday, October 23, 2016 at 9:38:58 AM UTC-7, Raphael Michel wrote: > > Hello, > > Am Fri, 21 Oct 2016 13:49:16 -0700 (PDT) > schrieb Mike Edmunds >: > >1. Should the result of ugettext_lazy somehow inherit from > >

Should ugettext_lazy return instanceof unicode? Or are reusable apps responsible for calling force_text a lot?

2016-10-21 Thread Mike Edmunds
A user has reported an issue with a Django reusable app I maintain, where they're passing my app a ugettext_lazy object that I ultimately pass to the requests package. Because instanceof(lazystr, unicode) is False, requests and urllib.urlenc