Should django.contrib.auth.authenticate check is_active?

2019-04-11 Thread Daniel Tao
This is essentially an RFC. I've become more familiar with Django's authentication backend system lately, and something has stood out to me that I'd like to draw attention to. A new site built with Django is likely to use the default ModelBackend, which includes a user_can_authenticate

Re: Proposal to re-open #27017 (updating only dirty fields in save())

2019-03-14 Thread Daniel Tao
_ONLY, enumerate these code paths and wrap them in select_for_update to ensure the data doesn't get into an inconsistent state? On Monday, January 28, 2019 at 8:00:21 AM UTC-6, Daniel Tao wrote: > > Hi! > > This is my first post on this list. I recently left a comment

Proposal to re-open #27017 (updating only dirty fields in save())

2019-01-28 Thread Daniel Tao
Hi! This is my first post on this list. I recently left a comment on #27017 requesting to re-open the topic of only saving dirty fields in save(). Tim Graham helpfully directed to #4102 and adv